From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2D5AC28EBD for ; Sun, 9 Jun 2019 16:49:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB4B12084A for ; Sun, 9 Jun 2019 16:49:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560098951; bh=3snimYtLiW81QvdIBMukURLkhku++669pMJK/Z942Rw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=fMMTJO2Qa0s1DY8/WC9ePxQIw0TxlOa0i0aT2mpuEUpoEXxmJE6HtXtNtzmtDleSw PP+p8s/+cOhRT5+WjzfQ7sIYwTcnTrkORrCfQf/lqdbP6lwet3TwSj3gdqH8rC8o/U zdY9Q71BfYa9u2CQwUvrwutvPWJwb6TzL9bwvv1g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731409AbfFIQtL (ORCPT ); Sun, 9 Jun 2019 12:49:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:48492 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729661AbfFIQtI (ORCPT ); Sun, 9 Jun 2019 12:49:08 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 004002070B; Sun, 9 Jun 2019 16:49:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560098948; bh=3snimYtLiW81QvdIBMukURLkhku++669pMJK/Z942Rw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Lv5lgMaGMA2j0v1iovgeEDCh5oRmF5isNngFZKzin0BlxI8519IbXtLFJ8sIXXhZg 9A7+WrVkdQzPORFMgk7YBBkNjdKsWppPeTbViE+A1ymiFmDw/I/CsxnIkEH26sAg9w t1W54AC9J6JJuvPGlhW9N/NMii/U4QeFUsYEMXfs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Paulo Zanoni , Daniel Vetter , Jani Nikula , Daniel Drake , Jian-Hong Pan , Jani Nikula , Joonas Lahtinen Subject: [PATCH 4.19 47/51] drm/i915/fbc: disable framebuffer compression on GeminiLake Date: Sun, 9 Jun 2019 18:42:28 +0200 Message-Id: <20190609164130.583496940@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190609164127.123076536@linuxfoundation.org> References: <20190609164127.123076536@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Daniel Drake commit 396dd8143bdd94bd1c358a228a631c8c895a1126 upstream. On many (all?) the Gemini Lake systems we work with, there is frequent momentary graphical corruption at the top of the screen, and it seems that disabling framebuffer compression can avoid this. The ticket was reported 6 months ago and has already affected a multitude of users, without any real progress being made. So, lets disable framebuffer compression on GeminiLake until a solution is found. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108085 Fixes: fd7d6c5c8f3e ("drm/i915: enable FBC on gen9+ too") Cc: Paulo Zanoni Cc: Daniel Vetter Cc: Jani Nikula Cc: # v4.11+ Reviewed-by: Paulo Zanoni Signed-off-by: Daniel Drake Signed-off-by: Jian-Hong Pan Signed-off-by: Jani Nikula Link: https://patchwork.freedesktop.org/patch/msgid/20190423092810.28359-1-jian-hong@endlessm.com (cherry picked from commit 1d25724b41fad7eeb2c3058a5c8190d6ece73e08) Signed-off-by: Joonas Lahtinen Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/i915/intel_fbc.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/gpu/drm/i915/intel_fbc.c +++ b/drivers/gpu/drm/i915/intel_fbc.c @@ -1267,6 +1267,10 @@ static int intel_sanitize_fbc_option(str if (!HAS_FBC(dev_priv)) return 0; + /* https://bugs.freedesktop.org/show_bug.cgi?id=108085 */ + if (IS_GEMINILAKE(dev_priv)) + return 0; + if (IS_BROADWELL(dev_priv) || INTEL_GEN(dev_priv) >= 9) return 1;