Re: [PATCH 04/34] leds: leds-pca955x: simplify getting the adapter of a client

Jacek Anaszewski
2019-06-09T11:17:49Z

On 6/9/19 1:05 PM, Pavel Machek wrote:
> On Sun 2019-06-09 13:03:40, Jacek Anaszewski wrote:
>> Hi Wolfram,
>>
>> Thank you for the patches.
>>
>> On 6/8/19 12:55 PM, Wolfram Sang wrote:
>>> We have a dedicated pointer for that, so use it. Much easier to read and
>>> less computation involved.
>>>
>>> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>>> ---
>>>
>>> Please apply to your subsystem tree.
>>>
>>> drivers/leds/leds-pca955x.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/leds/leds-pca955x.c b/drivers/leds/leds-pca955x.c
>>> index a9f5dad55956..460626d81c6a 100644
>>> --- a/drivers/leds/leds-pca955x.c
>>> +++ b/drivers/leds/leds-pca955x.c
>>> @@ -432,7 +432,7 @@ static int pca955x_probe(struct i2c_client *client,
>>> int ngpios = 0;
>>> chip = &pca955x_chipdefs[id->driver_data];
>>> - adapter = to_i2c_adapter(client->dev.parent);
>>> + adapter = client->adapter;
>>> pdata = dev_get_platdata(&client->dev);
>>> if (!pdata) {
>>> pdata = pca955x_get_pdata(client, chip);
>>>
>>
>> For both 4/34 and 5/34:
>>
>> Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
>
> 4 and 5:
>
> Acked-by: Pavel Machek <pavel@ucw.cz>
>
> But I wonder if it should go through the leds tree?

Yes, I missed that "Please apply to your subsystem tree." comment.
And this change relies on the existing code.

Applied 4/34 and 5/34 to the for-next branch of linux-leds.git.

Thanks.

--
Best regards,
Jacek Anaszewski