Re: [PATCH 01/11] perf intel-pt: Add new packets for PEBS via PT

Adrian Hunter
2019-06-13T16:32:55Z

On 12/06/19 4:28 PM, Arnaldo Carvalho de Melo wrote:
> Em Wed, Jun 12, 2019 at 03:52:11PM +0300, Adrian Hunter escreveu:
>> On 12/06/19 3:41 PM, Arnaldo Carvalho de Melo wrote:
>>> Em Wed, Jun 12, 2019 at 08:58:00AM +0300, Adrian Hunter escreveu:
>>>> On 12/06/19 3:09 AM, Arnaldo Carvalho de Melo wrote:
>>>>> Em Mon, Jun 10, 2019 at 10:27:53AM +0300, Adrian Hunter escreveu:
>>>>>> Add 3 new packets to supports PEBS via PT, namely Block Begin Packet (BBP),
>>>>>> Block Item Packet (BIP) and Block End Packet (BEP). PEBS data is encoded
>>>>>> into multiple BIP packets that come between BBP and BEP. The BEP packet
>>>>>> might be associated with a FUP packet. That is indicated by using a
>>>>>> separate packet type (INTEL_PT_BEP_IP) similar to other packets types with
>>>>>> the _IP suffix.
>>>>>>
>>>>>> Refer to the Intel SDM for more information about PEBS via PT.
>>>>>
>>>>> In these cases would be nice to provide an URL and page number, for
>>>>> convenience.
>>>>
>>>> Intel SDM:
>>>>
>>>> https://software.intel.com/en-us/articles/intel-sdm
>>>>
>>>> May 2019 version: Vol. 3B 18.5.5.2 PEBS output to Intel® Processor Trace
>>>
>>> Thanks! I'll add to that cset.
>>>
>>> What about the kernel bits?
>>
>> Awaiting V2, here is a link to the patches:
>>
>> https://lore.kernel.org/lkml/20190502105022.15534-1-alexander.shishkin@linux.intel.com/
>
> yeah, I saw those and PeterZ's comments, that is why I asked about them
> :-)
>
>> There is also still a few more tools changes dependent upon the kernel patches.
>
> But I think I can go ahead and push the decoder bits, when the kernel
> patches get merged we'll be almost ready to make full use of what it
> provides, right?

Yes