Re: [PATCH v6 03/19] kernel: Unify update_vsyscall implementation

Thomas Gleixner
2019-06-14T13:07:31Z

On Fri, 14 Jun 2019, Vincenzo Frascino wrote:
> On 6/14/19 1:19 PM, Thomas Gleixner wrote:
> > On Fri, 14 Jun 2019, Vincenzo Frascino wrote:
> >> On 6/14/19 12:10 PM, Thomas Gleixner wrote:
> >>> On Thu, 30 May 2019, Vincenzo Frascino wrote:
> >>>> +
> >>>> + if (__arch_use_vsyscall(vdata)) {
> >>>> + vdata[CS_HRES_COARSE].cycle_last =
> >>>> + tk->tkr_mono.cycle_last;
> >>>> + vdata[CS_HRES_COARSE].mask =
> >>>> + tk->tkr_mono.mask;
> >>>> + vdata[CS_HRES_COARSE].mult =
> >>>> + tk->tkr_mono.mult;
> >>>
> >>> These line breaks make it really hard to read. Can you fold in the patch
> >>> below please?
> >>>
> >>
> >> Thanks for this. I will do it in v7.
> >
> > Talking about v7. I'd like to get this into 5.3. That means you'd have to
> > rebase it on
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git hyperv-next
> >
> > to avoid the hyperv conflict. I'll sort this out with the hyperv folks how
> > I can get these bits as a base for a tip branch which holds all the vdso
> > pieces.
> >
>
> Ok, I will rebase and test the patches against the hyperv-next branch. Could you
> please let me know when all the bits are sorted?

Don't worry. Just post it against that branch and I'll sort out the
logistics independently.

Thanks,

tglx