From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nishka Dasgupta <nishkadg.linux@gmail.com>
Cc: devel@driverdev.osuosl.org, valdis.kletnieks@vt.edu,
florian.c.schilhabel@googlemail.com, tiny.windzz@gmail.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
colin.king@canonical.com, larry.finger@lwfinger.net
Subject: Re: [PATCH 1/2] staging: rtl8712: r8712_setdatarate_cmd(): Change
Date: Mon, 10 Jun 2019 17:33:33 +0300 [thread overview]
Message-ID: <20190610143333.GA1915@kadam> (raw)
In-Reply-To: <98b587c9-df5b-0905-ab8f-69a4bae296b0@gmail.com>
On Mon, Jun 10, 2019 at 10:02:27AM +0530, Nishka Dasgupta wrote:
> On 07/06/19 7:45 PM, Dan Carpenter wrote:
> > Probably you sent this patch unintentionally. The subject doesn't make
> > any sort of sense. :P
>
> So the problem with the subject line is that git send-email and vim (as
> configured on my laptop) tend to line-wrap even the subject line. Since I
> have two patches that do the same thing for different functions, I felt I
> should have the driver and the function name in the subject line (to avoid
> confusion between the patches and to allow for easy searching later). But
> that doesn't leave enough space in the subject line for "Change return
> values/type" or any other descriptive message. What should I do?
>
I don't really care.
[PATCH] staging: rtl8712: clean up r8712_setdatarate_cmd() return type
regards,
dan carpenter
prev parent reply other threads:[~2019-06-10 14:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 14:06 [PATCH 1/2] staging: rtl8712: r8712_setdatarate_cmd(): Change Nishka Dasgupta
2019-06-07 14:06 ` [PATCH 2/2] staging: rtl8712: r8712_createbss_cmd(): Change Nishka Dasgupta
2019-06-07 14:18 ` Dan Carpenter
2019-06-07 14:15 ` [PATCH 1/2] staging: rtl8712: r8712_setdatarate_cmd(): Change Dan Carpenter
2019-06-10 4:32 ` Nishka Dasgupta
2019-06-10 14:33 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190610143333.GA1915@kadam \
--to=dan.carpenter@oracle.com \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=larry.finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=nishkadg.linux@gmail.com \
--cc=tiny.windzz@gmail.com \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox