From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FADAC31E41 for ; Mon, 10 Jun 2019 15:12:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25B6920862 for ; Mon, 10 Jun 2019 15:12:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560179538; bh=h7mmrFketdGrH+jhcRTn+JLEZxAETRUZZjfI6AMHvCA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=g6cuzgD8apkRswcyrvOE6hgSkNMdt5eFmIKyoWynd13A0foT+FdWHZkWw8R6iZsRE UHDqNimQ9IhCgPypvMs9qk4KSIQJ3nSh2atRmuG6Yob3quwco2/Is6JgaCVXE3DbKS Fwrfps1LB1s4diShP63047QbP4sTqeGENcrd+7Zc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391102AbfFJPMR (ORCPT ); Mon, 10 Jun 2019 11:12:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:33874 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389322AbfFJPMQ (ORCPT ); Mon, 10 Jun 2019 11:12:16 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9D408207E0; Mon, 10 Jun 2019 15:12:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560179536; bh=h7mmrFketdGrH+jhcRTn+JLEZxAETRUZZjfI6AMHvCA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hf0QAKqPWs3ENU591+37VscvqlxLG+/JbxsSF6qbnzU1/X5YVItVSaPjV2rM4rQ09 B2uL15jg0n+qvd/+BGm0HDMCWtU1ZX9y71BYyMplT4kmo4siqp9sMlIAHDG9P9BcSE gwGJufDeL6oNOgTo8oiicRdA7nzeTfFWE1hgQOPk= Date: Mon, 10 Jun 2019 17:12:13 +0200 From: Greg KH To: Michal Simek Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, johan@kernel.org, Nava kishore Manne , Jiri Slaby , linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] serial: xilinx_uartps: Fix warnings in the driver Message-ID: <20190610151213.GA7305@kroah.com> References: <20190610144425.GC31086@kroah.com> <888c7d0a-28dc-978c-662a-e96ee3863c41@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <888c7d0a-28dc-978c-662a-e96ee3863c41@xilinx.com> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 10, 2019 at 05:06:57PM +0200, Michal Simek wrote: > On 10. 06. 19 16:44, Greg KH wrote: > > On Mon, Jun 10, 2019 at 10:44:55AM +0200, Michal Simek wrote: > >> From: Nava kishore Manne > >> > >> This patch fixes the below warning > >> > >> -->Symbolic permissions 'S_IRUGO' are not preferred. > >> Consider using octal permissions '0444'. > >> -->macros should not use a trailing semicolon. > >> -->line over 80 characters. > >> -->void function return statements are not generally useful. > >> -->Prefer 'unsigned int' to bare use of 'unsigned'. > >> > >> Signed-off-by: Nava kishore Manne > >> Signed-off-by: Michal Simek > >> --- > >> > >> Happy to split it if needed. > > > > Please split. Do not do more than one "logical thing" per patch. > > > > And the subject is not correct, there are no general "warnings", these > > are all checkpatch warnings, not a build issue. > > ok. Will do. Any issue with second patch? It will change your user/kernel api but hey, it's your call, it looks like a nice fix to me :) thanks, greg k-h