From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE718C31E40 for ; Mon, 10 Jun 2019 15:25:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AEE21208E3 for ; Mon, 10 Jun 2019 15:25:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560180346; bh=ZW4R91QDmRfH9azlM/uSwSTSj7wDQXeKgtSkREaj4cY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=WNhjDJShz1Qet9LJzFnOnyK+JUQxtYscO1FsS3c3J8+IYe2rV5V8reROZl2r3cCNE 56LY/8FleVEyTpFoG+eMGAwqkg/BlSqZmEyLSR/MJ4cihqKOr7R37qfravFcIvxdCt sGkup5mtIk9NnXWQLiCFdAdC1zH/S+Rz1A+YizCo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390222AbfFJPZp (ORCPT ); Mon, 10 Jun 2019 11:25:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:40578 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389293AbfFJPZp (ORCPT ); Mon, 10 Jun 2019 11:25:45 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1A253206C3; Mon, 10 Jun 2019 15:25:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560180344; bh=ZW4R91QDmRfH9azlM/uSwSTSj7wDQXeKgtSkREaj4cY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WVetzT/qmHeSi5jL/NUgUVF5GujCXMUHqbQc30TGaB/FBxlcH+3FrnLFsox20AmtV 410GCw8chUJfN0QGMLJ/kHPVwCMvNvqQD0eE+CxYbVPkmNwbYu2KfsKaVqeCR8HdJy Ytt3zq0sHN6fhILygA/Rz8FnTJwCZtTEfcPpmXFQ= Date: Mon, 10 Jun 2019 17:25:42 +0200 From: Greg KH To: Arnaldo Carvalho de Melo Cc: Ivan Babrou , Miguel Ojeda , Peter Zijlstra , Josh Poimboeuf , Ingo Molnar , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-kernel , Linux Kbuild mailing list , kernel-team Subject: Re: Linux 4.19 and GCC 9 Message-ID: <20190610152542.GA4132@kroah.com> References: <20190517050931.GB32367@kroah.com> <20190517073813.GB2589@hirez.programming.kicks-ass.net> <20190517085126.GA3249@kroah.com> <20190517152200.GI8945@kernel.org> <4FE2D490-F379-4CAE-9784-9BF81B7FE258@kernel.org> <20190610151407.GS21245@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190610151407.GS21245@kernel.org> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 10, 2019 at 12:14:07PM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Jun 10, 2019 at 12:21:51AM -0700, Ivan Babrou escreveu: > > Looks like 4.19.49 received some patches for GCC 9+, but unfortunately > > perf still doesn't want to compile: > > > > [07:15:32]In file included from /usr/include/string.h:635, > > [07:15:32] from util/debug.h:7, > > [07:15:32] from builtin-help.c:15: > > [07:15:32]In function 'strncpy', > > [07:15:32] inlined from 'add_man_viewer' at builtin-help.c:192:2, > > [07:15:32] inlined from 'perf_help_config' at builtin-help.c:284:3: > > [07:15:32]/usr/include/x86_64-linux-gnu/bits/string3.h:126:10: error: > > '__builtin_strncpy' output truncated before terminating nul copying as > > many bytes from a string as its length [-Werror=stringop-truncation] > > [07:15:32] 126 | return __builtin___strncpy_chk (__dest, __src, __len, > > __bos (__dest)); > > [07:15:32] | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > [07:15:32]builtin-help.c: In function 'perf_help_config': > > [07:15:32]builtin-help.c:187:15: note: length computed here > > [07:15:32] 187 | size_t len = strlen(name); > > [07:15:32] | ^~~~~~~~~~~~ > > [07:15:32]cc1: all warnings being treated as errors > > The patch below should've taken care of that, and it has a Fixes: tag, > i.e. the stable scripts should've noticed that, and it was noticed with > gcc 8.2. No, stable scripts do not always pick up the "Fixes:" tag, they are only guaranteed to pick up the "cc: stable@" tag. Sometimes we catch the fixes ones too, but not always by far. Anyway, I'll queue this patch up after this next round of kernels are released, thanks! greg k-h