From: Dmitry Osipenko <digetx@gmail.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
Joseph Lo <josephl@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/6] clocksource/drivers/tegra: Set and use timer's period
Date: Mon, 10 Jun 2019 19:43:57 +0300 [thread overview]
Message-ID: <20190610164400.11830-4-digetx@gmail.com> (raw)
In-Reply-To: <20190610164400.11830-1-digetx@gmail.com>
The of_clk structure has a period field that is set up initially by
timer_of_clk_init(), that period value need to be adjusted for a case of
TIMER1-9 that are running at a fixed rate that doesn't match the clock's
rate. Note that the period value is currently used only by some of the
clocksource drivers internally and hence this is just a minor cleanup
change that doesn't fix anything.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/clocksource/timer-tegra.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/clocksource/timer-tegra.c b/drivers/clocksource/timer-tegra.c
index 810b4e7435cf..646b3530c2d2 100644
--- a/drivers/clocksource/timer-tegra.c
+++ b/drivers/clocksource/timer-tegra.c
@@ -71,9 +71,9 @@ static int tegra_timer_shutdown(struct clock_event_device *evt)
static int tegra_timer_set_periodic(struct clock_event_device *evt)
{
void __iomem *reg_base = timer_of_base(to_timer_of(evt));
+ unsigned long period = timer_of_period(to_timer_of(evt));
- writel_relaxed(TIMER_PTV_EN | TIMER_PTV_PER |
- ((timer_of_rate(to_timer_of(evt)) / HZ) - 1),
+ writel_relaxed(TIMER_PTV_EN | TIMER_PTV_PER | (period - 1),
reg_base + TIMER_PTV);
return 0;
@@ -297,6 +297,7 @@ static int __init tegra_init_timer(struct device_node *np, bool tegra20,
cpu_to->clkevt.rating = rating;
cpu_to->clkevt.cpumask = cpumask_of(cpu);
cpu_to->of_base.base = timer_reg_base + base;
+ cpu_to->of_clk.period = DIV_ROUND_UP(rate, HZ);
cpu_to->of_clk.rate = rate;
irq_set_status_flags(cpu_to->clkevt.irq, IRQ_NOAUTOEN);
--
2.21.0
next prev parent reply other threads:[~2019-06-10 16:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 16:43 [PATCH v2 0/6] Few more cleanups for tegra-timer Dmitry Osipenko
2019-06-10 16:43 ` [PATCH v2 1/6] clocksource/drivers/tegra: Restore timer rate on Tegra210 Dmitry Osipenko
2019-06-12 8:30 ` Jon Hunter
2019-06-12 16:02 ` Dmitry Osipenko
2019-06-10 16:43 ` [PATCH v2 2/6] clocksource/drivers/tegra: Remove duplicated use of per_cpu_ptr Dmitry Osipenko
2019-06-14 15:48 ` Jon Hunter
2019-06-10 16:43 ` Dmitry Osipenko [this message]
2019-06-14 15:48 ` [PATCH v2 3/6] clocksource/drivers/tegra: Set and use timer's period Jon Hunter
2019-06-14 16:45 ` Dmitry Osipenko
2019-06-17 10:51 ` Jon Hunter
2019-06-17 14:04 ` Dmitry Osipenko
2019-06-18 8:40 ` Jon Hunter
2019-06-18 9:41 ` Dmitry Osipenko
2019-06-10 16:43 ` [PATCH v2 4/6] clocksource/drivers/tegra: Drop unneeded typecasting in one place Dmitry Osipenko
2019-06-14 15:48 ` Jon Hunter
2019-06-10 16:43 ` [PATCH v2 5/6] clocksource/drivers/tegra: Add verbose definition for 1MHz constant Dmitry Osipenko
2019-06-14 15:48 ` Jon Hunter
2019-06-10 16:44 ` [PATCH v2 6/6] clocksource/drivers/tegra: Restore base address before cleanup Dmitry Osipenko
2019-06-14 15:48 ` Jon Hunter
2019-06-14 16:51 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190610164400.11830-4-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=jonathanh@nvidia.com \
--cc=josephl@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pdeschrijver@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox