From: Greg KH <gregkh@linuxfoundation.org>
To: Oded Gabbay <oded.gabbay@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 8/8] habanalabs: enable 64-bit DMA mask in POWER9
Date: Tue, 11 Jun 2019 11:58:57 +0200 [thread overview]
Message-ID: <20190611095857.GB24058@kroah.com> (raw)
In-Reply-To: <20190611092144.11194-1-oded.gabbay@gmail.com>
On Tue, Jun 11, 2019 at 12:21:44PM +0300, Oded Gabbay wrote:
> +bool hl_pci_parent_is_phb4(struct hl_device *hdev)
> +{
> + struct pci_dev *parent_port = hdev->pdev->bus->self;
> +
> + if ((parent_port->vendor == PCI_VENDOR_ID_IBM) &&
> + (parent_port->device == PCI_DEVICE_ID_IBM_PHB4)) {
> + hdev->power9_64bit_dma_enable = 1;
> + return true;
> + }
> +
> + hdev->power9_64bit_dma_enable = 0;
> + return false;
> +}
That feels like a big hack. ppc doesn't have any "what arch am I
running on?" runtime call? Did you ask on the ppc64 mailing list? I'm
ok to take this for now, but odds are you need a better fix for this
sometime...
thanks,
greg k-h
next prev parent reply other threads:[~2019-06-11 9:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 9:21 [PATCH v2 8/8] habanalabs: enable 64-bit DMA mask in POWER9 Oded Gabbay
2019-06-11 9:58 ` Greg KH [this message]
2019-06-11 11:47 ` Oded Gabbay
2019-06-11 15:17 ` Christoph Hellwig
2019-06-11 15:26 ` Greg KH
2019-06-11 17:03 ` Oded Gabbay
2019-06-11 17:22 ` Oded Gabbay
2019-06-11 22:53 ` Benjamin Herrenschmidt
2019-06-12 5:45 ` Oliver O'Halloran
2019-06-12 8:17 ` Benjamin Herrenschmidt
2019-06-12 6:25 ` Oded Gabbay
2019-06-12 8:18 ` Benjamin Herrenschmidt
2019-06-12 6:35 ` Oliver O'Halloran
2019-06-12 6:53 ` Christoph Hellwig
2019-06-12 11:48 ` Oliver O'Halloran
2019-06-15 12:12 ` Oded Gabbay
2019-06-16 9:55 ` Christoph Hellwig
2019-06-16 11:24 ` Oded Gabbay
2019-06-17 8:19 ` Christoph Hellwig
2019-06-17 8:35 ` Oded Gabbay
2019-06-24 6:53 ` Oded Gabbay
2019-06-24 6:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190611095857.GB24058@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oded.gabbay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox