From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13AB5C4321A for ; Tue, 11 Jun 2019 18:55:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 39C0921773 for ; Tue, 11 Jun 2019 18:55:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="c6xH5/Qv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404061AbfFKSzO (ORCPT ); Tue, 11 Jun 2019 14:55:14 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:38728 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392161AbfFKSzO (ORCPT ); Tue, 11 Jun 2019 14:55:14 -0400 Received: by mail-pg1-f193.google.com with SMTP id v11so7459332pgl.5 for ; Tue, 11 Jun 2019 11:55:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=f3Fru+mwaeeiACG0X3g8c6CHiLSWKaplSTQC87ROeuQ=; b=c6xH5/Qvawf6qJjZ/xM+E56es8JaiVT0/DwVftgp6f87+AJuA/RU/4CQiSYxjtTfmG PSGytVbNJaOJtBjFzeOwwwcZDYYtXTZmoKwnT7IqB4KcdYfiPUlVDqNFeWYP6/AJw9uO rrLzkJOifPfW/e9lmiCnGCeMRGrhln8IV1Ne8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=f3Fru+mwaeeiACG0X3g8c6CHiLSWKaplSTQC87ROeuQ=; b=UB0rG4YryWd++pAFQ5OP6vtS9uZRSr1x6OvvhaTV3NqOyIG0J+vhIKCLtQwzwCBwLx 7ST4UhVzCirTe5EjcEn2B6yCdvwD/o4qA3wiZXNFCY1vFCzjV7khvSuY2zDderpOMSdc JV+UgHnZFaz1FjKG1Y4tXfsC9PS7e6eRcnuIWnasZLNmIaRE3kGP/+p23w/V0a68sORj sgvMnszEXS3E+GAEZNKJmGVIUwBrM9YENjwucZJFG2qqtfTH7JTkzgLIc3vOuX6dTjzB 9mU7r5Mu0BZWXYcGzlMZIdhlmDDC4DUzpTP+ElxwX6Nf8U5lN/PamIOhSa4ZZVr0I7zy S+1A== X-Gm-Message-State: APjAAAVg+TpViQdf7cJvI1AjA65Dr7M8+Wkm3HwzDmpNxO7qvV71u5Np rLhPEunOlGglhrJMwSmYAkMZFw== X-Google-Smtp-Source: APXvYqykLtoCMjK8ld6JD/RyOsTdfyoOM9u/UwTo1BXGOV4lbmZpi4MRGTiLpIKmeU10fMKb1YddfA== X-Received: by 2002:a62:4dc5:: with SMTP id a188mr82792699pfb.8.1560279313566; Tue, 11 Jun 2019 11:55:13 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id a186sm17123614pfa.188.2019.06.11.11.55.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Jun 2019 11:55:12 -0700 (PDT) Date: Tue, 11 Jun 2019 11:55:11 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Sathya Prakash , Chaitra P B , Suganath Prabu Subramani , "James E.J. Bottomley" , "Martin K. Petersen" , MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: mpt3sas: Mark expected switch fall-through Message-ID: <201906111153.4413672DE8@keescook> References: <20190611150219.GA19152@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190611150219.GA19152@embeddedor> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 11, 2019 at 10:02:19AM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > This patch fixes the following warning: > > drivers/scsi/mpt3sas/mpt3sas_base.c: In function ‘_base_update_ioc_page1_inlinewith_perf_mode’: > drivers/scsi/mpt3sas/mpt3sas_base.c:4510:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > if (ioc->high_iops_queues) { > ^ > drivers/scsi/mpt3sas/mpt3sas_base.c:4530:2: note: here > case MPT_PERF_MODE_LATENCY: > ^~~~ > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > This patch is part of the ongoing efforts to enable > -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva Fixes: 30cb97023f38 ("scsi: mpt3sas: Introduce perf_mode module parameter") Reviewed-by: Kees Cook -Kees > --- > drivers/scsi/mpt3sas/mpt3sas_base.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c > index e6377ec07f6c..9fefcd1e9c97 100644 > --- a/drivers/scsi/mpt3sas/mpt3sas_base.c > +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c > @@ -4527,6 +4527,7 @@ _base_update_ioc_page1_inlinewith_perf_mode(struct MPT3SAS_ADAPTER *ioc) > ioc_info(ioc, "performance mode: balanced\n"); > return; > } > + /* Fall through */ > case MPT_PERF_MODE_LATENCY: > /* > * Enable interrupt coalescing on all reply queues > -- > 2.21.0 > -- Kees Cook