From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B5E3C4321A for ; Tue, 11 Jun 2019 12:51:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 68913212F5 for ; Tue, 11 Jun 2019 12:51:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728890AbfFKMvd (ORCPT ); Tue, 11 Jun 2019 08:51:33 -0400 Received: from mga18.intel.com ([134.134.136.126]:7600 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727225AbfFKMvc (ORCPT ); Tue, 11 Jun 2019 08:51:32 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jun 2019 05:51:31 -0700 X-ExtLoop1: 1 Received: from smile.fi.intel.com (HELO smile) ([10.237.68.145]) by orsmga008.jf.intel.com with ESMTP; 11 Jun 2019 05:51:29 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1hagFM-0005EC-E8; Tue, 11 Jun 2019 15:51:28 +0300 Date: Tue, 11 Jun 2019 15:51:28 +0300 From: Andy Shevchenko To: Charles Keepax Cc: wsa@the-dreams.de, mika.westerberg@linux.intel.com, jarkko.nikula@linux.intel.com, linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, benjamin.tissoires@redhat.com, jbroadus@gmail.com, patches@opensource.cirrus.com Subject: Re: [PATCH v4 0/7] I2C IRQ Probe Improvements Message-ID: <20190611125128.GV9224@smile.fi.intel.com> References: <20190611123101.25264-1-ckeepax@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190611123101.25264-1-ckeepax@opensource.cirrus.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 11, 2019 at 01:30:54PM +0100, Charles Keepax wrote: > This series attempts to align as much IRQ handling into the > probe path as possible. Note that I don't have a great setup > for testing these patches so they are mostly just build tested > and need careful review and testing before any of them are > merged. > > The series brings the ACPI path inline with the way the device > tree path handles the IRQ entirely at probe time. However, > it still leaves any IRQ specified through the board_info as > being handled at device time. In that case we need to cache > something from the board_info until probe time, which leaves > any alternative solution with something basically the same as > the current handling although perhaps caching more stuff. Thank you! This one looks good. Reviewed-by: Andy Shevchenko > > Thanks, > Charles > > See previous discussions: > - https://lkml.org/lkml/2019/2/15/989 > - https://www.spinics.net/lists/linux-i2c/msg39541.html > > Charles Keepax (7): > i2c: core: Allow whole core to use i2c_dev_irq_from_resources > i2c: acpi: Use available IRQ helper functions > i2c: acpi: Factor out getting the IRQ from ACPI > i2c: core: Make i2c_acpi_get_irq available to the rest of the I2C core > i2c: core: Move ACPI IRQ handling to probe time > i2c: core: Move ACPI gpio IRQ handling into i2c_acpi_get_irq > i2c: core: Tidy up handling of init_irq > > drivers/i2c/i2c-core-acpi.c | 58 ++++++++++++++++++++++++++++++++------------- > drivers/i2c/i2c-core-base.c | 11 +++++---- > drivers/i2c/i2c-core.h | 9 +++++++ > 3 files changed, 56 insertions(+), 22 deletions(-) > > -- > 2.11.0 > -- With Best Regards, Andy Shevchenko