From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1091CC4321A for ; Tue, 11 Jun 2019 15:27:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9E82208E3 for ; Tue, 11 Jun 2019 15:26:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560266819; bh=1zBlTS3Nie+mVMEnxT8ngtbUEWBVODf4UqfieGxASKw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=t6FwUbQanIv14tO+dNTPjS2+gMm+usi8FCzcwfv1bSl/6rqUdtuwkWaysSmzha2/I j1/72So7CTD/pSdR65AxD5iJjosASOlXY4jPXDs0BKGMIpCGHNQ0igNh4X2KD41ubn BbkgJPJhqZAGav78IisA9q64uDxT2qPZXCZJwC98= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390464AbfFKP07 (ORCPT ); Tue, 11 Jun 2019 11:26:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:57472 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387864AbfFKP06 (ORCPT ); Tue, 11 Jun 2019 11:26:58 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8E6252080A; Tue, 11 Jun 2019 15:26:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560266818; bh=1zBlTS3Nie+mVMEnxT8ngtbUEWBVODf4UqfieGxASKw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R6z3c2Wfvs1aSYFX2p/bQ8TdbkA8+VWR6+YduaGWCiMIADIM2sRkbsl9+iTmO40/8 0se38PEGyvAGb8TRdb4ph0aPgJ9chqojwEkY83ethTGWXuIeDWvW8gZ+wT3xrk47KY NzuGx81caV4zNIhtctzfiYZVsHOilPnq/uVdW9rI= Date: Tue, 11 Jun 2019 17:26:55 +0200 From: Greg KH To: Christoph Hellwig , Oded Gabbay Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 8/8] habanalabs: enable 64-bit DMA mask in POWER9 Message-ID: <20190611152655.GA3972@kroah.com> References: <20190611092144.11194-1-oded.gabbay@gmail.com> <20190611095857.GB24058@kroah.com> <20190611151753.GA11404@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190611151753.GA11404@infradead.org> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 11, 2019 at 08:17:53AM -0700, Christoph Hellwig wrote: > On Tue, Jun 11, 2019 at 11:58:57AM +0200, Greg KH wrote: > > That feels like a big hack. ppc doesn't have any "what arch am I > > running on?" runtime call? Did you ask on the ppc64 mailing list? I'm > > ok to take this for now, but odds are you need a better fix for this > > sometime... > > That isn't the worst part of it. The whole idea of checking what I'm > running to set a dma mask just doesn't make any sense at all. Oded, I thought I asked if there was a dma call you should be making to keep this type of check from being needed. What happened to that? As Christoph points out, none of this should be needed, which is what I thought I originally said :) thanks, greg k-h