From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Song Liu <songliubraving@fb.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kernel Team <Kernel-team@fb.com>,
David Carrillo Cisneros <davidca@fb.com>,
Milian Wolff <milian.wolff@kdab.com>,
Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH] perf script/intel-pt: set synth_opts.callchain for use_browser > 0
Date: Tue, 11 Jun 2019 12:47:22 -0300 [thread overview]
Message-ID: <20190611154722.GC13332@redhat.com> (raw)
In-Reply-To: <F8963F4B-46FF-41D2-B261-6DD2EE898D93@fb.com>
Em Tue, Jun 11, 2019 at 07:18:09AM +0000, Song Liu escreveu:
>
>
> > On Jun 10, 2019, at 11:45 PM, Adrian Hunter <adrian.hunter@intel.com> wrote:
> > On 11/06/19 2:42 AM, Song Liu wrote:
> >> +++ b/tools/perf/util/intel-pt.c
> >> @@ -2588,7 +2588,7 @@ int intel_pt_process_auxtrace_info(union perf_event *event,
> >> } else {
> >> itrace_synth_opts__set_default(&pt->synth_opts,
> >> session->itrace_synth_opts->default_no_sample);
> >> - if (use_browser != -1) {
> >> + if (use_browser > 0) {
> > That code has changed recently. Refer:
> > https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=perf/core&id=26f19c2eb7e54
> Thanks for a better fix! I was using Arnaldo's perf/urgent branch, and missed
> this one.
Your report shows this one should move to perf/urgent, will try to do
that after processing a large perf/core batch...
- Arnaldo
prev parent reply other threads:[~2019-06-11 15:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 23:42 [PATCH] perf script/intel-pt: set synth_opts.callchain for use_browser > 0 Song Liu
2019-06-11 6:45 ` Adrian Hunter
2019-06-11 7:18 ` Song Liu
2019-06-11 15:47 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190611154722.GC13332@redhat.com \
--to=acme@redhat.com \
--cc=Kernel-team@fb.com \
--cc=adrian.hunter@intel.com \
--cc=davidca@fb.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=milian.wolff@kdab.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox