From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A32EEC4321A for ; Tue, 11 Jun 2019 17:32:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 75DE1207E0 for ; Tue, 11 Jun 2019 17:32:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YMRYA3VR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406217AbfFKRcc (ORCPT ); Tue, 11 Jun 2019 13:32:32 -0400 Received: from mail-pf1-f169.google.com ([209.85.210.169]:37057 "EHLO mail-pf1-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406020AbfFKRcc (ORCPT ); Tue, 11 Jun 2019 13:32:32 -0400 Received: by mail-pf1-f169.google.com with SMTP id 19so7022326pfa.4; Tue, 11 Jun 2019 10:32:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=LdNek+APXMhQxGgX0MguFd69wGyOuhCblzXrvmRZCos=; b=YMRYA3VRKjSCw7WuIs4loHfaTNq/EkdqBxzCZW8lO0l5/TpUkkuHmyrveObkjJd/FN 7D+8m7nLrnGxl1dhn1DRvS7DwMJSoKaZ5Gj2aH4xr2mR7x19bundu0YaF9WMzUfQrok2 DLi1AM0KWVU3+38AWUMHa7uNGdjAOGzLu2x4W0KkTEcEdL5q8NriBOvIHgBK3lbpixKx pdqJvv2M8ZfZoR22oBkGA0jhMMCOnj+GwYi2rs4PqL+hnTdeytQCIRHbKJJnU8HmnFR4 S/sCW3h728Lc/CYCo2CDszu+ScCW/fUhj5UY17HAQ51Kf6qZImjneOvV1VxjkIlOwQs3 T5fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=LdNek+APXMhQxGgX0MguFd69wGyOuhCblzXrvmRZCos=; b=EVMyLMrpvAwm2mtzC82kSYlGEM4/uZRWTSjquXqVBH4OoRuZIntnMrxroKutdsKWEO DQl18Um2V6rwAvV2rHaNRY3qiW0mkdcLl0ALP3BgUGFp+4qoJXpX1Nq0LwhiL6gAToyS rxCyl/t3moM6Fc1a7GhA5DEpfVa7rQAWRiYII43R2Q4AhnqMKXh9zFi4fKhBk1jqaBBi tEt86XFjgLuyNedX5umZ0PgTQyRmc5d5H0g4rElpDTzl1KLUloVdS8EVh3Iq4Py/I0sF kA3jbSlePahRomNPVY4vc8fc7G3Jl82/UIiGh/M/msHljYziGpfORVvXzv9ag55dCl0f X+zg== X-Gm-Message-State: APjAAAWIftFt1O+Ll7cTFfZ9TfE0yf6ApkYclzfPLY1HtS18ULG8EzuS Kc5gQolyrsBMyPC+IWOTfh2LvRv51kQ= X-Google-Smtp-Source: APXvYqzUV4n559KLHREKXiOWj9aNpTjayPMRLtpmaie/lolGJxTYizAR61u29Ck5OfgOYKxsgGUQOQ== X-Received: by 2002:a63:68c5:: with SMTP id d188mr21618397pgc.429.1560274350901; Tue, 11 Jun 2019 10:32:30 -0700 (PDT) Received: from dtor-ws ([2620:15c:202:201:3adc:b08c:7acc:b325]) by smtp.gmail.com with ESMTPSA id d123sm28189279pfc.144.2019.06.11.10.32.30 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 11 Jun 2019 10:32:30 -0700 (PDT) Date: Tue, 11 Jun 2019 10:32:28 -0700 From: "dmitry.torokhov@gmail.com" To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Hui Wang , Xiaoxiao Liu , XiaoXiao Liu , "peter.hutterer@who-t.net" , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Xiaojian Cao , "zhangfp1@lenovo.com" , Naoki Saito , Hideo Kawase Subject: Re: =?utf-8?B?562U5aSNOiDnrZTlpI06IOetlA==?= =?utf-8?B?5aSNOiBbUEFUQ0g=?= =?utf-8?Q?=5D?= input: alps-fix the issue alps cs19 trackstick do not work. Message-ID: <20190611173228.GD143729@dtor-ws> References: <20190610104310.qa5snt7jpcljodfv@pali> <5587ddb9-fb5f-03db-ac11-a696c85c5f2f@canonical.com> <20190611072333.nd4va4q2m5epmukc@pali> <20190611170707.GA143729@dtor-ws> <20190611171707.tydk7rsmtzmjohky@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190611171707.tydk7rsmtzmjohky@pali> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 11, 2019 at 07:17:07PM +0200, Pali Rohár wrote: > On Tuesday 11 June 2019 10:07:07 dmitry.torokhov@gmail.com wrote: > > On Tue, Jun 11, 2019 at 09:23:33AM +0200, Pali Rohár wrote: > > > On Tuesday 11 June 2019 12:32:33 Hui Wang wrote: > > > > On 2019/6/11 上午11:23, Hui Wang wrote: > > > > > On 2019/6/11 上午11:05, Xiaoxiao Liu wrote: > > > > > > Hi Pali, > > > > > > > > > > > > I discussed with our FW team about this problem. > > > > > > We think the V8 method means a touchpad feature  and does not fit > > > > > > the CS19 trackpoint device. > > > > > > CS19 TrackPoint needn't  use any Absolute (Raw) mode and is usually > > > > > > use standard mouse data. > > > > > > CS19 TrackPoint device is a completely different device with > > > > > > DualPoint device of Dell/HP. > > > > > > CS19 TrackPoint device is independent  of Touchpad. (Touchpad is > > > > > > connecting by I2C, TrackPoint is directly connecting with PS2 port.) > > > > > > And it has completely another FW. > > > > > > > > > > > > So we think it is better to use the mouse mode for CS19 trackpoint. > > > > > > > > > > Maybe here is some mis-understanding,  the mouse mode here doesn't mean > > > > > we use psmouse-base.c for cs19 (bare ps/2 mouse), we plan to use > > > > > trackpoint.c to drive this HW, so this trackpoint has all features a > > > > > trackpoint should have. > > > > > > > > > And I sent a patch one month ago to let the the trackpoint.c to drive this > > > > HW: https://www.spinics.net/lists/linux-input/msg61341.html, maybe that > > > > patch is reference. > > > > > > So instead of creating blacklist, you should check for TP_VARIANT_ALPS > > > in alps.c and disallow its usage. > > > > > > Or maybe better, move trackpoint.c detect code before alsp.c detect code > > > in psmouse-base. And no changes in alps.c are needed. > > > > I'd be very cautions of moving around the protocol detection. It is very > > fragile, so if we can detect trackpoint-only case in alps.c and skip on > > to trackpoint I would prefer it. > > The main problem is that proposed trackpoint-only check in alps.c is > basically what trackpoint.c is doing for checking if device is > trackpoint (via function trackpoint_start_protocol()). > > So I'm not sure now what is the best solution... Unfortunately currently trackpoint is being probed only after we tried Elan, Genius, and Logitech PS2++ protocols, and I am not sure if moving trackpoint around will disturb them or not. I do not think there is much code duplication by pulling limited version of trackpoint detection code into alps.c and then have it bail out when it sees trackpoint-only device so trackpoint.c can handle it properly. Thanks. -- Dmitry