Re: [PATCH] vmw_ballon: no need to check return value of debugfs_create functions

Greg Kroah-Hartman
2019-06-12T11:35:43Z

On Tue, Jun 11, 2019 at 07:36:36PM +0000, Nadav Amit wrote:
> Please change the title of the patch to “vmw_balloon” (it is currently
> “vmw_ballon”).

Oops, will fix, sorry about that.

> > On Jun 11, 2019, at 11:55 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> >
> > When calling debugfs functions, there is no need to ever check the
> > return value. The function can work or not, but the code logic should
> > never do something different based on this.
>
> I remember I saw a discussion about it, and didn’t know the resolution.
>
> If that's the decision (assuming debugfs initialization always succeeds),
> and after fixing the title of the patch:
>
> Acked-by: Nadav Amit <namit@vmware.com>

Thanks for the review!

greg k-h