From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EEBFC4321A for ; Tue, 11 Jun 2019 19:11:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F35802184C for ; Tue, 11 Jun 2019 19:11:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407463AbfFKTLm (ORCPT ); Tue, 11 Jun 2019 15:11:42 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:37887 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404048AbfFKTLm (ORCPT ); Tue, 11 Jun 2019 15:11:42 -0400 X-Originating-IP: 37.205.120.66 Received: from localhost (unknown [37.205.120.66]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 94AF6C0005; Tue, 11 Jun 2019 19:11:32 +0000 (UTC) Date: Tue, 11 Jun 2019 21:11:28 +0200 From: Alexandre Belloni To: Aisheng Dong Cc: Anson Huang , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "a.zummo@towertech.it" , "ulf.hansson@linaro.org" , Peng Fan , Daniel Baluta , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-rtc@vger.kernel.org" , dl-linux-imx Subject: Re: [PATCH 2/3] rtc: imx-sc: Make compatible string more generic Message-ID: <20190611191128.GK25472@piout.net> References: <20190611063333.48501-1-Anson.Huang@nxp.com> <20190611063333.48501-2-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/06/2019 10:57:17+0000, Aisheng Dong wrote: > > From: Anson.Huang@nxp.com [mailto:Anson.Huang@nxp.com] > > Sent: Tuesday, June 11, 2019 2:34 PM > > > > i.MX system controller RTC driver can support all i.MX SoCs with system > > controller inside, this patch makes the compatible string more generic to > > support other i.MX SoCs with system controller inside, such as i.MX8QM etc.. > > > > Signed-off-by: Anson Huang > > Reviewed-by: Dong Aisheng > > Regards > Dong Aisheng > > > --- > > drivers/rtc/rtc-imx-sc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/rtc/rtc-imx-sc.c b/drivers/rtc/rtc-imx-sc.c index > > c933045..38ef3ca 100644 > > --- a/drivers/rtc/rtc-imx-sc.c > > +++ b/drivers/rtc/rtc-imx-sc.c > > @@ -178,7 +178,7 @@ static int imx_sc_rtc_probe(struct platform_device > > *pdev) } > > > > static const struct of_device_id imx_sc_dt_ids[] = { > > - { .compatible = "fsl,imx8qxp-sc-rtc", }, Don't you want to keep that compatible for backward compatibility? > > + { .compatible = "fsl,imx-sc-rtc", }, > > {} > > }; > > MODULE_DEVICE_TABLE(of, imx_sc_dt_ids); > > -- > > 2.7.4 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com