From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26F30C46477 for ; Wed, 12 Jun 2019 09:52:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F308120874 for ; Wed, 12 Jun 2019 09:52:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437735AbfFLJwl (ORCPT ); Wed, 12 Jun 2019 05:52:41 -0400 Received: from mga14.intel.com ([192.55.52.115]:48959 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437415AbfFLJwl (ORCPT ); Wed, 12 Jun 2019 05:52:41 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jun 2019 02:52:40 -0700 X-ExtLoop1: 1 Received: from smile.fi.intel.com (HELO smile) ([10.237.68.145]) by orsmga005.jf.intel.com with ESMTP; 12 Jun 2019 02:52:35 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1hazvl-0007ql-Rx; Wed, 12 Jun 2019 12:52:33 +0300 Date: Wed, 12 Jun 2019 12:52:33 +0300 From: Andy Shevchenko To: Rajneesh Bhardwaj Cc: linux-kernel@vger.kernel.org, x86@kernel.org, bp@suse.de, Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , Kan Liang , Peter Zijlstra , platform-driver-x86@vger.kernel.org, Qiuxu Zhuo , Srinivas Pandruvada , Len Brown , Thomas Gleixner , Linux PM Subject: Re: [Patch v2] x86/cpu: Add Ice Lake NNPI to Intel family Message-ID: <20190612095233.GE9224@smile.fi.intel.com> References: <20190606012419.13250-1-rajneesh.bhardwaj@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190606012419.13250-1-rajneesh.bhardwaj@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 06, 2019 at 06:54:19AM +0530, Rajneesh Bhardwaj wrote: > Add the CPUID model number of Ice Lake Neural Network Processor for Deep > Learning Inference (ICL-NNPI) to the Intel family list. Ice Lake NNPI uses > model number 0x9D and this will be documented in a future version of Intel > Software Development Manual. > #define INTEL_FAM6_ICELAKE_MOBILE 0x7E > +#define INTEL_FAM6_ICELAKE_NNPI 0x9D What "I" stands for? For me sounds like it's redundant here or something like NNP_DLI would be better (because somewhere we have _NP as for Network Processor). -- With Best Regards, Andy Shevchenko