From: Kishon Vijay Abraham I <kishon@ti.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, <kishon@ti.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH 3/6] phy: usb: phy-brcm-usb: Remove sysfs attributes upon driver removal
Date: Wed, 12 Jun 2019 15:58:00 +0530 [thread overview]
Message-ID: <20190612102803.25398-4-kishon@ti.com> (raw)
In-Reply-To: <20190612102803.25398-1-kishon@ti.com>
From: Florian Fainelli <f.fainelli@gmail.com>
We are not destroying the sysfs attribute groupe we registered during
the probe function which will make subsequent probe calls to that
driver fail. Correct that with adding a remove function which only
removes those attributes since the reference counting on clocks did its
job already.
Fixes: 415060b21f31 ("phy: usb: phy-brcm-usb: Add ability to force DRD mode to host or device")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
drivers/phy/broadcom/phy-brcm-usb.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/phy/broadcom/phy-brcm-usb.c b/drivers/phy/broadcom/phy-brcm-usb.c
index f59b1dc30399..292d5b3fc66c 100644
--- a/drivers/phy/broadcom/phy-brcm-usb.c
+++ b/drivers/phy/broadcom/phy-brcm-usb.c
@@ -376,6 +376,13 @@ static int brcm_usb_phy_probe(struct platform_device *pdev)
return PTR_ERR_OR_ZERO(phy_provider);
}
+static int brcm_usb_phy_remove(struct platform_device *pdev)
+{
+ sysfs_remove_group(&pdev->dev.kobj, &brcm_usb_phy_group);
+
+ return 0;
+}
+
#ifdef CONFIG_PM_SLEEP
static int brcm_usb_phy_suspend(struct device *dev)
{
@@ -441,6 +448,7 @@ MODULE_DEVICE_TABLE(of, brcm_usb_dt_ids);
static struct platform_driver brcm_usb_driver = {
.probe = brcm_usb_phy_probe,
+ .remove = brcm_usb_phy_remove,
.driver = {
.name = "brcmstb-usb-phy",
.owner = THIS_MODULE,
--
2.17.1
next prev parent reply other threads:[~2019-06-12 10:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 10:27 [GIT PULL v2] PHY: for 5.2-rc Kishon Vijay Abraham I
2019-06-12 10:27 ` [PATCH 1/6] phy: qcom-qusb2: fix missing assignment of ret when calling clk_prepare_enable Kishon Vijay Abraham I
2019-06-12 10:27 ` [PATCH 2/6] phy: renesas: rcar-gen2: Fix memory leak at error paths Kishon Vijay Abraham I
2019-06-12 10:28 ` Kishon Vijay Abraham I [this message]
2019-06-12 10:28 ` [PATCH 4/6] dt-bindings: phy: tegra-xusb: List PLL power supplies Kishon Vijay Abraham I
2019-06-12 10:28 ` [PATCH 5/6] phy: tegra: xusb: Add Tegra124 " Kishon Vijay Abraham I
2019-06-12 10:28 ` [PATCH 6/6] phy: tegra: xusb: Add Tegra210 " Kishon Vijay Abraham I
2019-06-21 6:11 ` [GIT PULL v2] PHY: for 5.2-rc Kishon Vijay Abraham I
2019-06-21 6:40 ` Greg Kroah-Hartman
2019-06-21 7:20 ` Kishon Vijay Abraham I
2019-06-27 13:16 ` Kishon Vijay Abraham I
2019-07-01 10:14 ` Greg Kroah-Hartman
2019-07-01 10:31 ` Kishon Vijay Abraham I
2019-07-01 13:06 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612102803.25398-4-kishon@ti.com \
--to=kishon@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox