From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nadav Amit <namit@vmware.com>
Cc: Julien Freche <jfreche@vmware.com>,
Pv-drivers <Pv-drivers@vmware.com>, Arnd Bergmann <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vmw_ballon: no need to check return value of debugfs_create functions
Date: Wed, 12 Jun 2019 13:35:38 +0200 [thread overview]
Message-ID: <20190612113538.GA14793@kroah.com> (raw)
In-Reply-To: <5A5203EB-A789-4C48-9C25-EF0C0CBCE5CD@vmware.com>
On Tue, Jun 11, 2019 at 07:36:36PM +0000, Nadav Amit wrote:
> Please change the title of the patch to “vmw_balloon” (it is currently
> “vmw_ballon”).
Oops, will fix, sorry about that.
> > On Jun 11, 2019, at 11:55 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> >
> > When calling debugfs functions, there is no need to ever check the
> > return value. The function can work or not, but the code logic should
> > never do something different based on this.
>
> I remember I saw a discussion about it, and didn’t know the resolution.
>
> If that's the decision (assuming debugfs initialization always succeeds),
> and after fixing the title of the patch:
>
> Acked-by: Nadav Amit <namit@vmware.com>
Thanks for the review!
greg k-h
prev parent reply other threads:[~2019-06-12 11:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 18:55 [PATCH] vmw_ballon: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-06-11 19:36 ` Nadav Amit
2019-06-12 11:35 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612113538.GA14793@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Pv-drivers@vmware.com \
--cc=arnd@arndb.de \
--cc=jfreche@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namit@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox