From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6975FC31E46 for ; Wed, 12 Jun 2019 13:11:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 455FF208C2 for ; Wed, 12 Jun 2019 13:11:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439387AbfFLNLp (ORCPT ); Wed, 12 Jun 2019 09:11:45 -0400 Received: from 8bytes.org ([81.169.241.247]:43616 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2439360AbfFLNLp (ORCPT ); Wed, 12 Jun 2019 09:11:45 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id 9C2EF64D; Wed, 12 Jun 2019 15:11:43 +0200 (CEST) Date: Wed, 12 Jun 2019 15:11:43 +0200 From: Joerg Roedel To: Jean-Philippe Brucker Cc: "alex.williamson@redhat.com" , "jacob.jun.pan@linux.intel.com" , "eric.auger@redhat.com" , "ashok.raj@intel.com" , "yi.l.liu@intel.com" , "robdclark@gmail.com" , "linux-kernel@vger.kernel.org" , "iommu@lists.linux-foundation.org" , Robin Murphy Subject: Re: [PATCH v2 0/4] iommu: Add device fault reporting API Message-ID: <20190612131143.GF21613@8bytes.org> References: <20190603145749.46347-1-jean-philippe.brucker@arm.com> <20190612081944.GB17505@8bytes.org> <0f21e1b2-837f-87ba-6cf3-f6490d9e2a57@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0f21e1b2-837f-87ba-6cf3-f6490d9e2a57@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 12, 2019 at 12:54:51PM +0100, Jean-Philippe Brucker wrote: > Thanks! As discussed I think we need to add padding into the iommu_fault > structure before this reaches mainline, to make the UAPI easier to > extend in the future. It's already possible to extend but requires > introducing a new ABI version number and support two structures. Adding > some padding would only require introducing new flags. If there is no > objection I'll send a one-line patch bumping the structure size to 64 > bytes (currently 48) Sounds good, please submit the patch. Regards, Joerg