From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA991C31E46 for ; Wed, 12 Jun 2019 13:39:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82054208CA for ; Wed, 12 Jun 2019 13:39:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560346751; bh=WBC3kV6boUG4g0ISh+/Q4tHQr5heRL1XoT+RzTqjx/c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=qJoHyEZp5N8TYgEtzliexRUtHTA+oUkBySF/wpLdYsIIv7qwi3sGH9Y1u5/IRwsyy Je7+pTB+VsngPSAuQfL3OjOhWNCw4zb/TViiBWfx1z3ZKkReOBD+BwuNh3SRWTI5VG ee2fFVPacTJNMZuadaLepZjHgXHmhUv5ExZ9C5YY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408432AbfFLNjL (ORCPT ); Wed, 12 Jun 2019 09:39:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:57392 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732411AbfFLNjF (ORCPT ); Wed, 12 Jun 2019 09:39:05 -0400 Received: from dragon (li1264-180.members.linode.com [45.79.165.180]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 29FDC20B1F; Wed, 12 Jun 2019 13:38:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560346744; bh=WBC3kV6boUG4g0ISh+/Q4tHQr5heRL1XoT+RzTqjx/c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jadukF9E0+CT+yi715fyqQx75FWd9SG+n5IHNuVSvny1BFdo4qJulitWVAdLiCDm+ dcXCnRt5p2izrUGcxU0FBywUIVl/Ontpx0aG5VLMjFxYO/y/itjIGLAjNgZEx3fOin RQYkQugxl/iZJwGadx+LOtSpkmAkB3OGKlkVDxVE= Date: Wed, 12 Jun 2019 21:38:22 +0800 From: Shawn Guo To: Igor Opaniuk Cc: Stefan Agner , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Linux ARM , robh+dt@kernel.org, mark.rutland@arm.com, s.hauer@pengutronix.de, kernel@pengutronix.de, Fabio Estevam , linux-imx@nxp.com, Marcel Ziswiler , Marcel Ziswiler Subject: Re: [PATCH 1/1] ARM: dts: imx6ull-colibri: enable UHS-I for USDHC1 Message-ID: <20190612132705.GJ11086@dragon> References: <20190606090612.16685-1-igor.opaniuk@gmail.com> <3b84f3cc6cd5399f25ebd8e1c8559c58@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 12, 2019 at 03:49:03PM +0300, Igor Opaniuk wrote: > Hi Stefan, > > On Wed, Jun 12, 2019 at 3:17 PM Stefan Agner wrote: > > > > On 06.06.2019 11:06, Igor Opaniuk wrote: > > > From: Igor Opaniuk > > > > > > Allows to use the SD interface at a higher speed mode if the card > > > supports it. For this the signaling voltage is switched from 3.3V to > > > 1.8V under the usdhc1's drivers control. > > > > > > Signed-off-by: Igor Opaniuk > > > --- > > > arch/arm/boot/dts/imx6ul.dtsi | 4 ++++ > > > arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi | 11 +++++++++-- > > > arch/arm/boot/dts/imx6ull-colibri.dtsi | 6 ++++++ > > > 3 files changed, 19 insertions(+), 2 deletions(-) > > > > > > diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi > > > index fc388b84bf22..91a0ced44e27 100644 > > > --- a/arch/arm/boot/dts/imx6ul.dtsi > > > +++ b/arch/arm/boot/dts/imx6ul.dtsi > > > @@ -857,6 +857,8 @@ > > > <&clks IMX6UL_CLK_USDHC1>, > > > <&clks IMX6UL_CLK_USDHC1>; > > > clock-names = "ipg", "ahb", "per"; > > > + fsl,tuning-step= <2>; > > > + fsl,tuning-start-tap = <20>; > > > bus-width = <4>; > > > status = "disabled"; > > > }; > > > @@ -870,6 +872,8 @@ > > > <&clks IMX6UL_CLK_USDHC2>; > > > clock-names = "ipg", "ahb", "per"; > > > bus-width = <4>; > > > + fsl,tuning-step= <2>; > > > + fsl,tuning-start-tap = <20>; > > > status = "disabled"; > > > }; > > > > > > diff --git a/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi > > > b/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi > > > index 006690ea98c0..7dc7770cf52c 100644 > > > --- a/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi > > > +++ b/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi > > > @@ -145,13 +145,20 @@ > > > }; > > > > > > &usdhc1 { > > > - pinctrl-names = "default"; > > > + pinctrl-names = "default", "state_100mhz", "state_200mhz", "sleep"; > > > pinctrl-0 = <&pinctrl_usdhc1 &pinctrl_snvs_usdhc1_cd>; > > > - no-1-8-v; > > > + pinctrl-1 = <&pinctrl_usdhc1_100mhz &pinctrl_snvs_usdhc1_cd>; > > > + pinctrl-2 = <&pinctrl_usdhc1_100mhz &pinctrl_snvs_usdhc1_cd>; > > > > Should that not be pinctrl_usdhc1_200mhz? > > > > Correct, thanks for pointing this out. > Taking into account that the patch was already accepted by Shawn, will > send another to fix this typo ASAP (added to my todo list). I just fixed it up on my branch. Shawn