Re: [PATCH v3 0/4] s390/crypto: Use -ENODEV instead of -EOPNOTSUPP

Cornelia Huck
2019-06-12T13:48:34Z

On Wed, 12 Jun 2019 15:33:02 +0200
David Hildenbrand <david@redhat.com> wrote:

> s390x crypto is one of the rare modules that returns -EOPNOTSUPP instead of
> -ENODEV in case HW support is not available.
>
> Convert to -ENODEV, so e.g., systemd's systemd-modules-load.service
> ignores this error properly.
>
> v2 -> v3:
> - "s390/pkey: Use -ENODEV instead of -EOPNOTSUPP"
> -- Also convert pkey_clr2protkey() as requested by Harald

Looks reasonable; my r-b still stands.

> - Add r-b's (thanks!)
>
> v1 -> v2:
> - Include
> -- "s390/crypto: ghash: Use -ENODEV instead of -EOPNOTSUPP"
> -- "s390/crypto: prng: Use -ENODEV instead of -EOPNOTSUPP"
> -- "s390/crypto: sha: Use -ENODEV instead of -EOPNOTSUPP"
>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Harald Freudenberger <freude@linux.ibm.com>
> Cc: Cornelia Huck <cohuck@redhat.com>
>
> David Hildenbrand (4):
> s390/pkey: Use -ENODEV instead of -EOPNOTSUPP
> s390/crypto: ghash: Use -ENODEV instead of -EOPNOTSUPP
> s390/crypto: prng: Use -ENODEV instead of -EOPNOTSUPP
> s390/crypto: sha: Use -ENODEV instead of -EOPNOTSUPP
>
> arch/s390/crypto/ghash_s390.c | 2 +-
> arch/s390/crypto/prng.c | 4 ++--
> arch/s390/crypto/sha1_s390.c | 2 +-
> arch/s390/crypto/sha256_s390.c | 2 +-
> arch/s390/crypto/sha512_s390.c | 2 +-
> drivers/s390/crypto/pkey_api.c | 8 ++++----
> 6 files changed, 10 insertions(+), 10 deletions(-)
>