From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90DACC31E45 for ; Thu, 13 Jun 2019 17:16:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 716CE2053B for ; Thu, 13 Jun 2019 17:16:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729316AbfFMRQz (ORCPT ); Thu, 13 Jun 2019 13:16:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57880 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725819AbfFLV1f (ORCPT ); Wed, 12 Jun 2019 17:27:35 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F2171C18B2E4; Wed, 12 Jun 2019 21:27:34 +0000 (UTC) Received: from krava (ovpn-204-42.brq.redhat.com [10.40.204.42]) by smtp.corp.redhat.com (Postfix) with SMTP id 4F68F5D9D5; Wed, 12 Jun 2019 21:27:33 +0000 (UTC) Date: Wed, 12 Jun 2019 23:27:32 +0200 From: Jiri Olsa To: Laura Abbott Cc: Jiri Olsa , Arnaldo Carvalho de Melo , Stephane Eranian , Florian Weimer , Linux Kernel Mailing List Subject: Re: perf build failure with newer glibc headers Message-ID: <20190612212732.GA14171@krava> References: <4c0a4264-7142-2e6d-540d-aa354700e0bb@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4c0a4264-7142-2e6d-540d-aa354700e0bb@redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 12 Jun 2019 21:27:35 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 12, 2019 at 03:23:12PM -0400, Laura Abbott wrote: > Hi, > > While doing some build experiments, I found a compile failure with perf and jvmti: > > BUILDSTDERR: gcc -Wp,-MD,./.xsk.o.d -Wp,-MT,xsk.o -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-jvmti/jvmti_agent.c:48:21: error: static declaration of 'gettid' follows non-static declaration > BUILDSTDERR: 48 | static inline pid_t gettid(void) > BUILDSTDERR: | ^~~~~~ > BUILDSTDERR: In file included from /usr/include/unistd.h:1170, > BUILDSTDERR: from jvmti/jvmti_agent.c:33: > BUILDSTDERR: /usr/include/bits/unistd_ext.h:40:16: note: previous declaration of 'gettid' was here > BUILDSTDERR: 40 | extern __pid_t gettid (void) __THROW; > BUILDSTDERR: | ^~~~~~ > > > This is with the newer glibc headers that came into Fedora earlier this week > (glibc-2.29.9000-27.fc31) It looks like the newer headers now define gettid > so the in file gettid no longer works. Note this was a custom build with > jvmti enabled as regular Fedora doesn't have it enabled which is why this > wasn't reported elsewhere. hum, I guess we need some version macro conditions if that's the case so this glibc version is available on rawhide now? I'll try to get some server with it thanks, jirka > > I don't know enough about either the glibc headers or perf to make a suggestion > on how to fix this but I'm happy to test. > > Thanks, > Laura