Re: [PATCH 4.14 00/81] 4.14.126-stable review

Sasha Levin
2019-06-13T16:38:32Z

On Thu, Jun 13, 2019 at 05:37:44PM +0200, Greg Kroah-Hartman wrote:
>On Thu, Jun 13, 2019 at 08:11:33AM -0700, Guenter Roeck wrote:
>> On 6/13/19 1:32 AM, Greg Kroah-Hartman wrote:
>> > This is the start of the stable review cycle for the 4.14.126 release.
>> > There are 81 patches in this series, all will be posted as a response
>> > to this one. If anyone has any issues with these being applied, please
>> > let me know.
>> >
>> > Responses should be made by Sat 15 Jun 2019 07:54:51 AM UTC.
>> > Anything received after that time might be too late.
>> >
>>
>> [early feedback]
>>
>> Building mips:nlm_xlp_defconfig ... failed (and other mips builds)
>> --------------
>> Error log:
>> /opt/buildbot/slave/stable-queue-4.14/build/arch/mips/kernel/prom.c: In function 'early_init_dt_add_memory_arch':
>> /opt/buildbot/slave/stable-queue-4.14/build/arch/mips/kernel/prom.c:44:14: error: 'PHYS_ADDR_MAX' undeclared
>>
>> The problem affects v4.14.y and all earlier branches.
>> PHYS_ADDR_MAX is indeed undeclared in those branches. It was introduced
>> with commit 1c4bc43ddfd52 ("mm/memblock: introduce PHYS_ADDR_MAX").
>
>Thanks, I've dropped the mips patch that caused this. I'll also drop it
>from the 4.4 and 4.9 trees.
>
>Sasha, I thought you had builders set up for stuff like this?

Yes, and apparently I was naive thinking that
'allmodconfig'/'allyesconfig' would catch these, but that's not the
case.

--
Thanks,
Sasha