[PATCH] usb: gadget: u_audio: Fixed variable declaration coding style issue

[PATCH] usb: gadget: u_audio: Fixed variable declaration coding style issue

[Jonas Stenvall]

Fixed a coding style issue, replacing unsigned with unsigned int.

Signed-off-by: Jonas Stenvall <jonas.stenvall.umea@gmail.com>
---
 drivers/usb/gadget/function/u_audio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/function/u_audio.c b/drivers/usb/gadget/function/u_audio.c
index fb5ed97572e5..56906d15fb55 100644
--- a/drivers/usb/gadget/function/u_audio.c
+++ b/drivers/usb/gadget/function/u_audio.c
@@ -40,7 +40,7 @@ struct uac_rtd_params {
 
 	void *rbuf;
 
-	unsigned max_psize;	/* MaxPacketSize of endpoint */
+	unsigned int max_psize;	/* MaxPacketSize of endpoint */
 	struct uac_req *ureq;
 
 	spinlock_t lock;
@@ -78,7 +78,7 @@ static const struct snd_pcm_hardware uac_pcm_hardware = {
 
 static void u_audio_iso_complete(struct usb_ep *ep, struct usb_request *req)
 {
-	unsigned pending;
+	unsigned int pending;
 	unsigned long flags, flags2;
 	unsigned int hw_ptr;
 	int status = req->status;
-- 
2.17.1

Re: [PATCH] usb: gadget: u_audio: Fixed variable declaration coding style issue

[Eugeniu Rosca]

Hi Jonas,

On Thu, Jun 13, 2019 at 11:34:33AM +0200, Jonas Stenvall wrote:
> Fixed a coding style issue, replacing unsigned with unsigned int.

No concerns on my side. FWIW, the 'bare use of unsigned' coding style
inconsistency is quite common in the USB gadget framework [1-2].

Depending on the feedback from the maintainers, I see below potential
outcomes for this patch (sorted by my personal estimation of chance):
 - we take it and we fix the rest on best-effort basis.
 - we kindly ask you to fix the issue globally in USB gadget space.
 - we don't care, as this is not a functional issue. We rather prefer to
   concentrate on functional problems.

Deciding on the above is a matter of maintainer's preference.

> 
> Signed-off-by: Jonas Stenvall <jonas.stenvall.umea@gmail.com>
> ---
>  drivers/usb/gadget/function/u_audio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

From my end:

Reviewed-by: Eugeniu Rosca <erosca@de.adit-jv.com>

[1] git grep -E "unsigned [^(int|short|char|long)]" -- drivers/usb/gadget/function | wc -l
32
[2] git grep -E "unsigned [^(int|short|char|long)]" -- drivers/usb/gadget | wc -l                    
99

-- 
Best Regards,
Eugeniu.