From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E853CC31E44 for ; Fri, 14 Jun 2019 06:53:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BAA9B2133D for ; Fri, 14 Jun 2019 06:53:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560495223; bh=wuUTXFN56UvawcDpp0upIqE8jR1yiNkVbrzRRp7qMFM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=unKXu7eO1UIdsmrbQkliGVSSY7mf5b4g4dMg84svE2ZmQQdl/RQHOvhDNZRNHklvu UiAlrC16xTNvks64LcF9X6llpPb81/7aF8syvqYlNUCL9qh4Lb9XPtHhO1YmbDOAVg TV9yRdFFq8v6GbqeWARlhOfHoSvwQ5FfINg1jhPQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726297AbfFNGxm (ORCPT ); Fri, 14 Jun 2019 02:53:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:38292 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725834AbfFNGxm (ORCPT ); Fri, 14 Jun 2019 02:53:42 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0BB3B20673; Fri, 14 Jun 2019 06:53:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560495221; bh=wuUTXFN56UvawcDpp0upIqE8jR1yiNkVbrzRRp7qMFM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1FSemE9FNDYxmgCQYzMONszZilvyP63OswdHEot/o2wMC3VwlKk942CueY5gw/5WE VJwdcpZlJRWNZZfHgKE3MDbsQO9tHoASvSmr2J/CvWxHDgUTmBwbAcd8t0oi7itxZ4 ESCybRUSBQv9D7x4hETjGfhG3vtXx1qWxhor05vM= Date: Fri, 14 Jun 2019 08:53:39 +0200 From: Greg Kroah-Hartman To: Andy Shevchenko Cc: Darren Hart , Andy Shevchenko , "Lee, Chun-Yi" , Platform Driver , Linux Kernel Mailing List Subject: Re: [PATCH 1/8] platform: x86: acer-wmi: no need to check return value of debugfs_create functions Message-ID: <20190614065339.GB21447@kroah.com> References: <20190612121258.19535-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 14, 2019 at 09:48:04AM +0300, Andy Shevchenko wrote: > On Wed, Jun 12, 2019 at 3:13 PM Greg Kroah-Hartman > wrote: > > > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do something different based on this. > > > > Also, because there is no need to save the file dentry, remove the > > variable that was saving it and just recursively delete the whole > > directory. > > > > Through which tree you want to proceed this? What ever is easier for you, I can take it through mine, as I have a lot of other patches like this queued up already, or it can go through yours. thanks, greg k-h