From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B1D4C31E4B for ; Fri, 14 Jun 2019 14:10:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E7CC21537 for ; Fri, 14 Jun 2019 14:10:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="Sc4aN3oy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728910AbfFNOKT (ORCPT ); Fri, 14 Jun 2019 10:10:19 -0400 Received: from mail.skyhub.de ([5.9.137.197]:44530 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727382AbfFNOKT (ORCPT ); Fri, 14 Jun 2019 10:10:19 -0400 Received: from zn.tnic (p200300EC2F097F0010F3CEDA9C41B474.dip0.t-ipconnect.de [IPv6:2003:ec:2f09:7f00:10f3:ceda:9c41:b474]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 208851EC0911; Fri, 14 Jun 2019 16:10:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1560521418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=m8x7R9c/EDsa4nv2hfjxZO5gkYQUphth/JS0Fj6Jfn0=; b=Sc4aN3oypEBEVK7xUH5ByZG+btRqYLVrnG7IwSqFefujK2n8NtFKwQaA2Yc0eqbsNWEZhi Qd7P2GwdcY56CClCgensKa6JWB05g3qCADjUn4AiM89m+qt8HHcF0QBNClutng4QM/B9Rd KeaADvNGn3fS9HfseCcZsmRD338mIqQ= Date: Fri, 14 Jun 2019 16:10:10 +0200 From: Borislav Petkov To: Fenghua Yu Cc: Thomas Gleixner , Ingo Molnar , H Peter Anvin , Christopherson Sean J , Ravi V Shankar , linux-kernel , x86 , Radim =?utf-8?B?S3LEjW3DocWZ?= , Paolo Bonzini Subject: Re: [RFC PATCH 2/3] x86/cpufeatures: Combine word 11 and 12 into new scattered features word 11 Message-ID: <20190614141010.GG2586@zn.tnic> References: <1560459064-195037-1-git-send-email-fenghua.yu@intel.com> <1560459064-195037-3-git-send-email-fenghua.yu@intel.com> <20190614114410.GD2586@zn.tnic> <20190614122749.GE2586@zn.tnic> <20190614131701.GA198207@romley-ivt3.sc.intel.com> <20190614134123.GF2586@zn.tnic> <20190614135105.GB198207@romley-ivt3.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190614135105.GB198207@romley-ivt3.sc.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 14, 2019 at 06:51:05AM -0700, Fenghua Yu wrote: > CPUID_7_1_EAX is defined in patch 0003. Should I combine patch 0002 and 0003 > into one patch? That was just an example diff. Generally, patches should do one logical thing. In this case, I'd suggest you make the kvm change the first and separate patch, from the other three. > Need to check CPUID_LNX_2 and CPUID_LNX_3 as well? Yes, all linux-defined feature words. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.