From: Borislav Petkov <bp@alien8.de>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: "Fenghua Yu" <fenghua.yu@intel.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>, "H Peter Anvin" <hpa@zytor.com>,
"Ravi V Shankar" <ravi.v.shankar@intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [RFC PATCH 2/3] x86/cpufeatures: Combine word 11 and 12 into new scattered features word 11
Date: Fri, 14 Jun 2019 16:21:39 +0200 [thread overview]
Message-ID: <20190614142139.GH2586@zn.tnic> (raw)
In-Reply-To: <20190614141424.GA12191@linux.intel.com>
On Fri, Jun 14, 2019 at 07:14:24AM -0700, Sean Christopherson wrote:
> This is wrong. KVM isn't complaining about shuffling the order of feature
> words, it's complaining that code is trying to do a reverse CPUID lookup
> to a feature that isn't in the reverse_cpuid table. Filtering out
> checks dynamically is just hiding bugs.
No no, reverse_cpuid is hardcoding our feature leafs. This is wrong as
we want to be able to change those. And reverse_cpuid[] should be able
to handle that.
KVM is complaining because he removed one leaf. He adds it later in
patch 3 as a Linux-defined leaf.
All that doesn't matter for KVM - if KVM wants to do reverse lookup,
then it should handle Linux-defined leafs just fine.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-06-14 14:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 20:51 [RFC PATCH 0/3] x86/cpufeatures: Re-arrange a few features and enumerate AVX512 BFLOAT16 intructions Fenghua Yu
2019-06-13 20:51 ` [RFC PATCH 1/3] x86/resctrl: Get max rmid and occupancy scale directly from CPUID instead of cpuinfo_x86 Fenghua Yu
2019-06-14 11:16 ` Borislav Petkov
2019-06-14 16:55 ` Fenghua Yu
2019-06-14 17:47 ` Borislav Petkov
2019-06-14 17:49 ` Fenghua Yu
2019-06-13 20:51 ` [RFC PATCH 2/3] x86/cpufeatures: Combine word 11 and 12 into new scattered features word 11 Fenghua Yu
2019-06-14 11:44 ` Borislav Petkov
2019-06-14 12:27 ` Borislav Petkov
2019-06-14 13:17 ` Fenghua Yu
2019-06-14 13:41 ` Borislav Petkov
2019-06-14 13:51 ` Fenghua Yu
2019-06-14 14:10 ` Borislav Petkov
2019-06-14 14:14 ` Sean Christopherson
2019-06-14 14:15 ` Fenghua Yu
2019-06-14 14:26 ` Borislav Petkov
2019-06-14 14:25 ` Fenghua Yu
2019-06-14 15:02 ` Borislav Petkov
2019-06-14 18:44 ` Fenghua Yu
2019-06-14 14:21 ` Borislav Petkov [this message]
2019-06-14 14:39 ` Sean Christopherson
2019-06-14 14:57 ` Borislav Petkov
2019-06-14 15:24 ` Sean Christopherson
2019-06-14 16:10 ` Borislav Petkov
2019-06-14 16:20 ` Sean Christopherson
2019-06-13 20:51 ` [RFC PATCH 3/3] x86/cpufeatures: Enumerate new AVX512 BFLOAT16 instructions Fenghua Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614142139.GH2586@zn.tnic \
--to=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=ravi.v.shankar@intel.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox