public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Markus Elfring <Markus.Elfring@web.de>,
	Jack Ping CHNG <jack.ping.chng@linux.intel.com>,
	kernel-janitors@vger.kernel.org,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Enrico Weigelt <lkml@metux.net>,
	Himanshu Jha <himanshujha199640@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] drivers: Provide devm_platform_ioremap_resource_byname()
Date: Fri, 14 Jun 2019 17:47:06 +0300	[thread overview]
Message-ID: <20190614144706.GO9224@smile.fi.intel.com> (raw)
In-Reply-To: <20190614141004.GC7234@kroah.com>

On Fri, Jun 14, 2019 at 04:10:04PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Jun 14, 2019 at 04:38:40PM +0300, Andy Shevchenko wrote:
> > +Cc: Jack Ping, who did internally the same
> > 
> > On Fri, Jun 14, 2019 at 03:26:25PM +0200, Markus Elfring wrote:
> > > From: Markus Elfring <elfring@users.sourceforge.net>
> > > Date: Fri, 14 Jun 2019 15:15:14 +0200
> > > 
> > > The functions “platform_get_resource_byname” and “devm_ioremap_resource”
> > > are called together in 181 source files.
> > > This implementation detail can be determined also with the help
> > > of the semantic patch language (Coccinelle software).
> > > 
> > > Wrap these two calls into another helper function.
> > > Thus a local variable does not need to be declared for a resource
> > > structure pointer before and a redundant argument can be omitted
> > > for the resource type.
> > 
> > This one makes sense.
> > Though I'm not sure Greg will see your message.
> 
> Nope, didn't see it, don't want to see it, it will only cause more work
> in the longrun...
> 
> > Rafael, maybe you can apply this one?
> 
> Um, don't go around maintainers please, that's rude.  

I won't do it, how should we proceed if de facto this functionality is good to
have besides the fact of coming new user in the future?

> There is a reason
> this specific developer is in my blacklist, and perhaps they should be
> in yours as well :)

Perhaps.

> I don't like adding new apis with no user.

Perhaps Jack Ping will send it as a first patch of his series where he utilizes
this functionality. Would it be acceptable?

That's why I Cc'ed him as well.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2019-06-14 14:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14 13:26 [PATCH] drivers: Provide devm_platform_ioremap_resource_byname() Markus Elfring
2019-06-14 13:38 ` Andy Shevchenko
2019-06-14 14:10   ` Greg Kroah-Hartman
2019-06-14 14:47     ` Andy Shevchenko [this message]
2019-06-14 15:32       ` Greg Kroah-Hartman
2019-06-14 16:14       ` Markus Elfring
2019-06-15  8:44         ` Julia Lawall
2019-06-15 10:23           ` Markus Elfring
2019-06-17  9:55     ` [PATCH] " Rafael J. Wysocki
2019-06-17 13:54       ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190614144706.GO9224@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=Markus.Elfring@web.de \
    --cc=bgolaszewski@baylibre.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=himanshujha199640@gmail.com \
    --cc=jack.ping.chng@linux.intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml@metux.net \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox