From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A769AC31E4B for ; Fri, 14 Jun 2019 14:52:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8624321537 for ; Fri, 14 Jun 2019 14:52:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728981AbfFNOwG (ORCPT ); Fri, 14 Jun 2019 10:52:06 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:45021 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727560AbfFNOwF (ORCPT ); Fri, 14 Jun 2019 10:52:05 -0400 X-Originating-IP: 90.88.23.150 Received: from localhost (aaubervilliers-681-1-81-150.w90-88.abo.wanadoo.fr [90.88.23.150]) (Authenticated sender: maxime.ripard@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 9853AFF807; Fri, 14 Jun 2019 14:51:58 +0000 (UTC) Date: Fri, 14 Jun 2019 16:51:58 +0200 From: Maxime Ripard To: =?utf-8?Q?Myl=C3=A8ne?= Josserand Cc: dmitry.torokhov@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com Subject: Re: [PATCH v1] Input: rotary-encoder - Add gpio as push button Message-ID: <20190614145158.ic5n4jauzigvcpru@flea> References: <20190614133651.28396-1-mylene.josserand@bootlin.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zhhrocqtd54h66wd" Content-Disposition: inline In-Reply-To: <20190614133651.28396-1-mylene.josserand@bootlin.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zhhrocqtd54h66wd Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Mylene, On Fri, Jun 14, 2019 at 03:36:51PM +0200, Myl=E8ne Josserand wrote: > Add the support of a gpio that can be defined as a push button. > Thanks to that, it is possible to emit a keycode in case of a > "push" event, if the rotary supports that. > > The keycode to emit is defined using "linux,code" property > (such as in gpio-keys). > > Signed-off-by: Myl=E8ne Josserand > --- > .../devicetree/bindings/input/rotary-encoder.txt | 5 +++ > drivers/input/misc/rotary_encoder.c | 50 ++++++++++++++++= ++++++ > 2 files changed, 55 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/rotary-encoder.txt b= /Documentation/devicetree/bindings/input/rotary-encoder.txt > index a644408b33b8..1cfce5d0b5c4 100644 > --- a/Documentation/devicetree/bindings/input/rotary-encoder.txt > +++ b/Documentation/devicetree/bindings/input/rotary-encoder.txt > @@ -22,6 +22,9 @@ Optional properties: > - wakeup-source: Boolean, rotary encoder can wake up the system. > - rotary-encoder,encoding: String, the method used to encode steps. > Supported are "gray" (the default and more common) and "binary". > +- push-gpio: a gpio to be used as a detection of a push from the rotary. According to Documentation/devicetree/bindings/gpio/gpio.txt, GPIO properties with a -gpio suffix are now deprecated in favor of the -gpios suffix. > +- linux,code: keycode to emit with the push-gpio of this rotary encoder. > + Required property in case "push-gpio"'s one is used. I guess we should make it clear in the property name that it's the keycode emitted at push. Otherwise, it will be ambiguous between the rotary itself, or the button. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --zhhrocqtd54h66wd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXQO0jQAKCRDj7w1vZxhR xfa/APwNihQsA19qm8pkGRWL3Qlt9LOqUvcojAJKnBgw5Ey79gD/an1E5acjkg+i vYdRBFvAGVoRBhf+EhuKBQMgH/N2mww= =iSqL -----END PGP SIGNATURE----- --zhhrocqtd54h66wd--