From: Thierry Reding <thierry.reding@gmail.com>
To: Nathan Huckleberry <nhuck@google.com>
Cc: jonathanh@nvidia.com, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH v2] memory: tegra: Fix -Wunused-const-variable
Date: Fri, 14 Jun 2019 18:02:34 +0200 [thread overview]
Message-ID: <20190614160234.GB28409@ulmo> (raw)
In-Reply-To: <20190613182610.238801-1-nhuck@google.com>
[-- Attachment #1: Type: text/plain, Size: 875 bytes --]
On Thu, Jun 13, 2019 at 11:26:10AM -0700, Nathan Huckleberry wrote:
> Clang produces the following warning
>
> drivers/memory/tegra/tegra124.c:36:28: warning: unused variable
> 'tegra124_mc_emem_regs' [-Wunused-const-variable]
> static const unsigned long tegra124_mc_emem_regs[] = {
> ^
>
> The only usage of this variable is from within an ifdef.
> It seems logical to move the variable into the ifdef as well.
>
> Cc: clang-built-linux@googlegroups.com
> Link: https://github.com/ClangBuiltLinux/linux/issues/526
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
> ---
> Changes from v1 -> v2:
> * Moved definition of tegra124_mc_emem_regs into existing ifdef
> drivers/memory/tegra/tegra124.c | 44 ++++++++++++++++-----------------
> 1 file changed, 22 insertions(+), 22 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-06-14 16:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 17:27 [PATCH] memory: tegra: Fix -Wunused-const-variable Nathan Huckleberry
2019-06-13 17:57 ` Nick Desaulniers
2019-06-13 18:26 ` [PATCH v2] " Nathan Huckleberry
2019-06-13 18:27 ` Nick Desaulniers
2019-06-14 16:02 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614160234.GB28409@ulmo \
--to=thierry.reding@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=nhuck@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox