From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56651C31E4B for ; Fri, 14 Jun 2019 17:00:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F3F021841 for ; Fri, 14 Jun 2019 17:00:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560531620; bh=ce0b3DG9OIB1bVx/nvR1jo4bmOp9hLrfm7OM5x/FWsA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ZAFxWqoqZiL5c1M9+htuNZgQYdD3XlrHj7zwzIKqocNT2hZD7bebrTGfwl2pisomb EdstUwaDp+TpPIkOzQ/xtATIJP2iu9CBZiLoMUCXSUMBOGDUXXL4LyUZUHZRlq3uWc 9OCaNdw4QC3Rb80AANzb394/TPIyGYTrjnZ4kl14= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726164AbfFNRAO (ORCPT ); Fri, 14 Jun 2019 13:00:14 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:46575 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725889AbfFNRAO (ORCPT ); Fri, 14 Jun 2019 13:00:14 -0400 Received: by mail-qt1-f195.google.com with SMTP id h21so3213660qtn.13; Fri, 14 Jun 2019 10:00:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GS1hGa817xEQ00srJV+PzwKtWWnIbCX8xB7ozEQ8PeA=; b=SziVNEb96Y3NHG5cI0sUpDirBmajlOGfVjSelfia2mBJeWUCqYrFvZxyvJh29lzVCl p4xWul+tbDIZtMisiTiewevPEegV/feRwVn9TgwL3Ai3RvoSxjCielu5i88b+G1GDt8X ZodO9PdmCGZxds27W5QpIC1Dd4CnQW6Mrs0fH8B+mCq+KiIgz6uiNWsWVsBCb8r9Kcg8 V7youdprjCTzgarBP9KZAUEsmmm/GTqkaLD4o56BcUxcKle5N7ZYi/oJ7RjNAv13kJmU jA1EN4KGDB3c3p1d74U/CV1Mkv9CZtiArWHfxj+5tMaNjPQS8CS91bH2gk7l+H9OtzTi hDEw== X-Gm-Message-State: APjAAAWwK2iMm10cml1uYqzRrF18oNGnKVWdHjHTmDIrjv7S2Y7DU45h 67Hrwkam/Ut2LFN0mmjka3q/OnwUEg== X-Google-Smtp-Source: APXvYqypc0vhDImV9CKnXnk341O4whOdSmNRzr7Vv8pyHogbMsYPOsNoVDRfEVwUDByeZtQNRMKJfg== X-Received: by 2002:ac8:1087:: with SMTP id a7mr67129150qtj.141.1560531613016; Fri, 14 Jun 2019 10:00:13 -0700 (PDT) Received: from localhost ([64.188.179.243]) by smtp.gmail.com with ESMTPSA id j141sm2139542qke.28.2019.06.14.10.00.12 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 14 Jun 2019 10:00:12 -0700 (PDT) Date: Fri, 14 Jun 2019 11:00:11 -0600 From: Rob Herring To: Dan Murphy Cc: jacek.anaszewski@gmail.com, pavel@ucw.cz, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/9] dt: bindings: Add multicolor class dt bindings documention Message-ID: <20190614170011.GA3277@bogus> References: <20190523190820.29375-1-dmurphy@ti.com> <20190523190820.29375-3-dmurphy@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190523190820.29375-3-dmurphy@ti.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 23, 2019 at 02:08:13PM -0500, Dan Murphy wrote: > Add DT bindings for the LEDs multicolor class framework. > > Signed-off-by: Dan Murphy > --- > .../bindings/leds/leds-class-multicolor.txt | 97 +++++++++++++++++++ > 1 file changed, 97 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds-class-multicolor.txt > > diff --git a/Documentation/devicetree/bindings/leds/leds-class-multicolor.txt b/Documentation/devicetree/bindings/leds/leds-class-multicolor.txt > new file mode 100644 > index 000000000000..e2a2ce3279cb > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/leds-class-multicolor.txt > @@ -0,0 +1,97 @@ > +* Multicolor LED properties > + > +Multicolor LEDs can consist of a RGB, RGBW or a RGBA LED clusters. These devices > +can be grouped together and also provide a modeling mechanism so that the > +cluster LEDs can vary in hue and intensity to produce a wide range of colors. > + > +The nodes and properties defined in this document are unique to the multicolor > +LED class. Common LED nodes and properties are inherited from the common.txt > +within this documentation directory. > + > +Required LED Child properties: > + - color : For multicolor LED support this property should be defined as > + LED_COLOR_ID_MULTI and further definition can be found in > + include/linux/leds/common.h. > + > +led-controller@30 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "ti,lp5024"; > + reg = <0x29>; > + > + multi-led@4 { Typically we sort by address order. > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <4>; > + color = ; > + function = LED_FUNCTION_ACTIVITY; > + > + led@12 { > + reg = <12>; > + color = ; > + }; > + > + led@13 { > + reg = <13>; > + color = ; > + }; > + > + led@14 { > + reg = <14>; > + color = ; > + }; > + }; > + > + /* Only support RGB no model defined */ I don't understand this comment. > + multi-led@1 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <1>; > + color = ; > + function = LED_FUNCTION_; ?? > + > + > + led@3 { > + reg = <3>; > + color = ; > + }; > + > + led@4 { > + reg = <4>; > + color = ; > + }; > + > + led@5 { > + reg = <5>; > + color = ; > + }; > + }; > + > + multi-led@2 { > + #address-cells = <1>; > + #size-cells = <0>; > + color = ; > + function = LED_FUNCTION_ACTIVITY; > + reg = <2>; > + ti,led-bank = <2 3 5>; > + > + led@6 { > + reg = <0x6>; > + color = ; > + led-sources = <6 9 15>; > + }; > + > + led@7 { > + reg = <0x7>; > + color = ; > + led-sources = <7 10 16>; > + }; > + > + led@8 { > + reg = <0x8>; > + color = ; > + led-sources = <8 11 17>; > + }; > + }; > + > +}; > -- > 2.21.0.5.gaeb582a983 >