From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6053C31E4B for ; Fri, 14 Jun 2019 18:53:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A11CB2184E for ; Fri, 14 Jun 2019 18:53:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726165AbfFNSxu (ORCPT ); Fri, 14 Jun 2019 14:53:50 -0400 Received: from mga03.intel.com ([134.134.136.65]:53649 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725809AbfFNSxu (ORCPT ); Fri, 14 Jun 2019 14:53:50 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jun 2019 11:53:49 -0700 X-ExtLoop1: 1 Received: from romley-ivt3.sc.intel.com ([172.25.110.60]) by fmsmga001.fm.intel.com with ESMTP; 14 Jun 2019 11:53:49 -0700 Date: Fri, 14 Jun 2019 11:44:23 -0700 From: Fenghua Yu To: Borislav Petkov Cc: Sean Christopherson , Thomas Gleixner , Ingo Molnar , H Peter Anvin , Ravi V Shankar , linux-kernel , x86 , Radim =?utf-8?B?S3LEjW3DocWZ?= , Paolo Bonzini Subject: Re: [RFC PATCH 2/3] x86/cpufeatures: Combine word 11 and 12 into new scattered features word 11 Message-ID: <20190614184423.GG198207@romley-ivt3.sc.intel.com> References: <1560459064-195037-3-git-send-email-fenghua.yu@intel.com> <20190614114410.GD2586@zn.tnic> <20190614122749.GE2586@zn.tnic> <20190614131701.GA198207@romley-ivt3.sc.intel.com> <20190614134123.GF2586@zn.tnic> <20190614141424.GA12191@linux.intel.com> <20190614141519.GC198207@romley-ivt3.sc.intel.com> <20190614142611.GI2586@zn.tnic> <20190614142550.GD198207@romley-ivt3.sc.intel.com> <20190614150219.GK2586@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190614150219.GK2586@zn.tnic> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 14, 2019 at 05:02:19PM +0200, Borislav Petkov wrote: > On Fri, Jun 14, 2019 at 07:25:51AM -0700, Fenghua Yu wrote: > > But without this small patch, CPUID_7_EDX is 17 instead of > > NCAPINTS(19)-1=18 in patch 0002. Of course CPUID_7_EDX is 18 correctly > > evetually after applying patch 0003 which add the word 12 back. > > Ok, then I guess the easiest should be if not remove defines from > cpuid_leafs but rename them, no? So I will re-name the defines in cpuid_leafs to CPUID_LNX_4 and CPUID_DUMMY to match status of word 11 and word 12. Hopefully that's ok? Thanks. -Fenghua