From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D751C31E4B for ; Fri, 14 Jun 2019 19:19:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0CA9220644 for ; Fri, 14 Jun 2019 19:19:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QUTkAVVY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726108AbfFNTTG (ORCPT ); Fri, 14 Jun 2019 15:19:06 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:39871 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725825AbfFNTTG (ORCPT ); Fri, 14 Jun 2019 15:19:06 -0400 Received: by mail-pf1-f194.google.com with SMTP id j2so2001126pfe.6; Fri, 14 Jun 2019 12:19:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=pdZCIoYkfFDkgl8kzCeEDsmfwf1PzfJjurY0dcIItS4=; b=QUTkAVVYi2/skfDf6DBwJ5ENDmGC5fkUGoIzzRYyJcxiUDpYts3JcnatvfK8vBf3tU CqYYiiXbTApyLk9CX1cVLHy6wXRLUjiDUqB2eIIjqqvRaFX6baWP3RUKlceXwmkNexHY c1MvmgAPBHTIL85FuASAGvveDfcILX6IjI4VuNNYPQ/tJ+KCw7v5Hz9NdoFMDso0w686 pMa5R8NNf4EyojnwyA32cYSc/6Ht7kBFrDqxHRP37lx5bmjSrkuPSvkltwfBor3Pa9Zc Gg0q8UhPQtvSNgQcriQoUVXtv9ZE4g38zZ8I83YFSKE2/CFE5ij/g24dUH5cTrAd/8zt gThw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pdZCIoYkfFDkgl8kzCeEDsmfwf1PzfJjurY0dcIItS4=; b=GDHA7EE51g3HxxF3NkZsBIEKmC3O2igHwedv07yNJqjjrCuYYRfMLrAD11nKTn9Bxx 9dDfaGSRYXUBsaMorgFXkYS2CNRAUkx6SqWZmOkWXdwgWR5nhuQHQ+WHlgFgscFM6BOG 9GDSipUj+t+WgsKTc9SIXE22BvH/uSECcNAdhRPwbzLYV6x3pdBBKGNXwuCW4Ad0A/qr 5/7U1WijVRJ5XM2PRCg3WPX3Rg/O8DvyFx6GQjA3jthE//yYuCLLcnC42NNb04yfhU7A wYIaTLFATqpD6Kx+zrhK05W742+iCTzUY00Xn5Dh9IPcnKS0Z0FJRaF2NHRmaPFGMib9 +JZA== X-Gm-Message-State: APjAAAUxFmhzeIVAKuAj0N0jAyGT6rrW2nYozJLMocdx7cHXNATbwi+e l23ecMKbzVcQesMdNkJTAqw= X-Google-Smtp-Source: APXvYqxEOlGI5oHrg4Xwdaz3mx7Yaq5Z51fHqlcWxHxcVFoODI2RRu8Vlox2N5WVZSNoC9ph2K9N1Q== X-Received: by 2002:a63:441c:: with SMTP id r28mr37334130pga.255.1560539944980; Fri, 14 Jun 2019 12:19:04 -0700 (PDT) Received: from dtor-ws ([2620:15c:202:201:3adc:b08c:7acc:b325]) by smtp.gmail.com with ESMTPSA id o20sm3209780pgj.70.2019.06.14.12.19.03 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 14 Jun 2019 12:19:04 -0700 (PDT) Date: Fri, 14 Jun 2019 12:19:02 -0700 From: Dmitry Torokhov To: Benson Leung Cc: Enrico Granata , Ting Shen , LKML , Nicolas Boichat , Pi-Hsun Shih , Enrico Granata , Enric Balletbo i Serra , Heiko Stuebner , Guenter Roeck , Brian Norris , Benson Leung , linux-input@vger.kernel.org, Colin Ian King , gwendal@chromium.org, Lee Jones Subject: Re: [PATCH] Input: cros_ec_keyb: mask out extra flags in event_type Message-ID: <20190614191902.GA150432@dtor-ws> References: <20190614065438.142867-1-phoenixshen@chromium.org> <20190614185533.GA142889@dtor-ws> <20190614190957.GA243443@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190614190957.GA243443@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 14, 2019 at 12:09:57PM -0700, Benson Leung wrote: > Hi Dmitry, > > On Fri, Jun 14, 2019 at 11:55:33AM -0700, Dmitry Torokhov wrote: > > On Fri, Jun 14, 2019 at 11:27:03AM -0700, Enrico Granata wrote: > > > On Thu, Jun 13, 2019 at 11:54 PM Ting Shen wrote: > > > > > > > > http://crosreview.com/1341159 added a EC_MKBP_HAS_MORE_EVENTS flag to > > > > the event_type field, the receiver side should mask out this extra bit when > > > > processing the event. > > > > > > > > Signed-off-by: Ting Shen > > > > > > Reviewed-by: Enrico Granata > > > > EC_MKBP_EVENT_TYPE_MASK is not in Linus' tree. It would be better to > > merge this path through whatever tree that is bringing in that > > definition. > > > > Acked-by: Dmitry Torokhov > > Yup, this looks like it's coming in through Lee's MFD tree, a series from > Gwendal to update cros_ec_commands.h. > > 784dd15c930f mfd: cros_ec: Fix event processing API > > That commit is in the immutable branch for v5.3 here: > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-cros-v5.3 > > I'd recommend the chrome-platform tree since we'll be pulling in that IB too > for some other refactoring Enric is working on. Yeah, I'm fine with this going through chrome-platform. Thanks. -- Dmitry