From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Tom Zanussi <tom.zanussi@linux.intel.com>,
Hulk Robot <hulkci@huawei.com>,
YueHaibing <yuehaibing@huawei.com>
Subject: [for-linus][PATCH 3/7] tracing: Make two symbols static
Date: Sat, 15 Jun 2019 08:42:19 -0400 [thread overview]
Message-ID: <20190615124312.912679595@goodmis.org> (raw)
In-Reply-To: 20190615124216.188179157@goodmis.org
From: YueHaibing <yuehaibing@huawei.com>
Fix sparse warnings:
kernel/trace/trace.c:6927:24: warning:
symbol 'get_tracing_log_err' was not declared. Should it be static?
kernel/trace/trace.c:8196:15: warning:
symbol 'trace_instance_dir' was not declared. Should it be static?
Link: http://lkml.kernel.org/r/20190614153210.24424-1-yuehaibing@huawei.com
Acked-by: Tom Zanussi <tom.zanussi@linux.intel.com>
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
kernel/trace/trace.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 1c80521fd436..83e08b78dbee 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -6923,7 +6923,7 @@ struct tracing_log_err {
static DEFINE_MUTEX(tracing_err_log_lock);
-struct tracing_log_err *get_tracing_log_err(struct trace_array *tr)
+static struct tracing_log_err *get_tracing_log_err(struct trace_array *tr)
{
struct tracing_log_err *err;
@@ -8192,7 +8192,7 @@ static const struct file_operations buffer_percent_fops = {
.llseek = default_llseek,
};
-struct dentry *trace_instance_dir;
+static struct dentry *trace_instance_dir;
static void
init_tracer_tracefs(struct trace_array *tr, struct dentry *d_tracer);
--
2.20.1
next prev parent reply other threads:[~2019-06-15 12:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-15 12:42 [for-linus][PATCH 0/7] tracing: Fixes for 5.2-rc4 Steven Rostedt
2019-06-15 12:42 ` [for-linus][PATCH 1/7] tracing: Fix out-of-range read in trace_stack_print() Steven Rostedt
2019-06-15 12:42 ` Steven Rostedt [this message]
2019-06-15 12:42 ` [for-linus][PATCH 4/7] tracing/uprobe: Fix NULL pointer dereference in trace_uprobe_create() Steven Rostedt
2019-06-15 12:42 ` [for-linus][PATCH 5/7] tracing/uprobe: Fix obsolete comment on trace_uprobe_create() Steven Rostedt
2019-06-15 12:42 ` [for-linus][PATCH 6/7] module: Fix livepatch/ftrace module text permissions race Steven Rostedt
2019-06-15 12:42 ` [for-linus][PATCH 7/7] ftrace: Fix NULL pointer dereference in free_ftrace_func_mapper() Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190615124312.912679595@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=hulkci@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tom.zanussi@linux.intel.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox