From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Shobhit Kukreti <shobhitkukreti@gmail.com>
Cc: Bastien Nocera <hadess@hadess.net>,
Hans de Goede <hdegoede@redhat.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: Resolve checkpatch error "that open brace { should be on the previous line" in the rtl8723bs driver
Date: Sat, 15 Jun 2019 20:53:55 +0200 [thread overview]
Message-ID: <20190615185355.GC10201@kroah.com> (raw)
In-Reply-To: <20190614021206.GA895@t-1000>
On Thu, Jun 13, 2019 at 07:12:10PM -0700, Shobhit Kukreti wrote:
> Cleaned up the code from the following files to get rid of
> check patch error "that open brace { should be on the previous line"
>
> drivers/staging/rtl8723bs/os_dep/mlme_linux.c
> drivers/staging/rtl8723bs/os_dep/recv_linux.c
> drivers/staging/rtl8723bs/os_dep/rtw_proc.c
> drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c
>
> Signed-off-by: Shobhit Kukreti <shobhitkukreti@gmail.com>
> ---
> drivers/staging/rtl8723bs/os_dep/mlme_linux.c | 14 ++---
> drivers/staging/rtl8723bs/os_dep/recv_linux.c | 76 ++++++++---------------
> drivers/staging/rtl8723bs/os_dep/rtw_proc.c | 6 +-
> drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 15 ++---
> drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c | 24 +++----
> 5 files changed, 47 insertions(+), 88 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/mlme_linux.c b/drivers/staging/rtl8723bs/os_dep/mlme_linux.c
> index aa2499f..6799ed4 100644
> --- a/drivers/staging/rtl8723bs/os_dep/mlme_linux.c
> +++ b/drivers/staging/rtl8723bs/os_dep/mlme_linux.c
> @@ -46,8 +46,7 @@ void rtw_os_indicate_connect(struct adapter *adapter)
> struct mlme_priv *pmlmepriv = &(adapter->mlmepriv);
>
> if ((check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) == true) ||
> - (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true))
> - {
> + (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true)) {
> rtw_cfg80211_ibss_indicate_connect(adapter);
> }
> else
> @@ -77,8 +76,8 @@ void rtw_reset_securitypriv(struct adapter *adapter)
>
> spin_lock_bh(&adapter->security_key_mutex);
>
> - if (adapter->securitypriv.dot11AuthAlgrthm == dot11AuthAlgrthm_8021X)/* 802.1x */
> - {
> + if (adapter->securitypriv.dot11AuthAlgrthm == dot11AuthAlgrthm_8021X) { /* 802.1x */
> +
> /* Added by Albert 2009/02/18 */
> /* We have to backup the PMK information for WiFi PMK Caching test item. */
> /* */
> @@ -106,8 +105,8 @@ void rtw_reset_securitypriv(struct adapter *adapter)
> adapter->securitypriv.ndisencryptstatus = Ndis802_11WEPDisabled;
>
> }
> - else /* reset values in securitypriv */
> - {
> + else { /* reset values in securitypriv */
> +
Trailing whitespace?
The comment should be on a new line, not on the same line.
thanks,
greg k-h
next prev parent reply other threads:[~2019-06-15 18:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 2:12 [PATCH] staging: rtl8723bs: Resolve checkpatch error "that open brace { should be on the previous line" in the rtl8723bs driver Shobhit Kukreti
2019-06-15 18:53 ` Greg Kroah-Hartman [this message]
2019-06-15 21:29 ` [PATCH v2] staging: rtl8723bs: Resolve checkpatch error "that open brace { should be on the previous line" in the rtl8723 driver Shobhit Kukreti
2019-06-16 8:13 ` Joe Perches
2019-06-16 13:11 ` Shobhit Kukreti
2019-06-16 16:19 ` [PATCH v3 0/3] Resolve checkpatch if/else brace style errors Shobhit Kukreti
2019-06-16 16:19 ` [PATCH v3 1/3] staging: rtl8723bs: Resolve checkpatch error "that open brace { should be on the previous line" in the rtl8723 driver Shobhit Kukreti
2019-06-18 7:00 ` Greg Kroah-Hartman
2019-06-19 0:37 ` [PATCH v4 0/3] Resolve if/else brace-style errors Shobhit Kukreti
2019-06-19 0:37 ` [PATCH v4 1/3] staging: rtl8723bs: Resolve checkpatch error "that open brace { should be on the previous line" in the rtl8723 driver Shobhit Kukreti
2019-06-19 0:37 ` [PATCH v4 2/3] staging: rtl8723bs: Resolve the checkpatch error: else should follow close brace '}' Shobhit Kukreti
2019-06-19 0:37 ` [PATCH v4 3/3] staging: rtl8723bs: Fix Indentation Error: code indent should use tabs where possible Shobhit Kukreti
2019-06-16 16:19 ` [PATCH v3 2/3] staging: rtl8723bs: Resolve the checkpatch error: else should follow close brace '}' Shobhit Kukreti
2019-06-16 16:19 ` [PATCH v3 3/3] staging: rtl8723bs: Fix Indentation Error: code indent should use tabs where possible Shobhit Kukreti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190615185355.GC10201@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shobhitkukreti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox