From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60244C31E49 for ; Sun, 16 Jun 2019 10:18:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 38A59216C8 for ; Sun, 16 Jun 2019 10:18:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560680290; bh=22Nyl8r5NyujEokw6IbfB3M3uwmZEcDVVxHqLyjGrAo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=PHT7GPmp7MtD6nDh2q2umMj8NBDBr0gHwMg6kYn5Ec2Y2+gAQJ3fvoiBHvok7aWUW u1cHvqU7EwqZV1M/jVlyVjSso+GOThfeglInkIMMYuWR1tc41xnVPWXMHdmJhNfoAq KJQzB6XMfpMJ1e8r5D2ufjOVW8vPYeK75bMeG5ks= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726438AbfFPKSI (ORCPT ); Sun, 16 Jun 2019 06:18:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:33050 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725861AbfFPKSI (ORCPT ); Sun, 16 Jun 2019 06:18:08 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 778A32084A; Sun, 16 Jun 2019 10:18:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560680287; bh=22Nyl8r5NyujEokw6IbfB3M3uwmZEcDVVxHqLyjGrAo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=t3Y/hPQk6Y8RrOPdI2Afc/IrTEmx6ELkPRXG2g3JQvnVpf0/lB8YuwpJDRo5pnqVG Qp/2WjOqyaRYXdrz2s5yzJn1wvEFF7IVaXzJ8py/MQL/yw3Ysj2wl4IwC2/kGmI/1e vcrL17OhNPhmcA+2889gkgcyOon4gipSdMgXs6v4= Date: Sun, 16 Jun 2019 11:18:02 +0100 From: Jonathan Cameron To: Melissa Wen Cc: Lars-Peter Clausen , Michael Hennerich , Stefan Popa , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman , Barry Song <21cnbao@gmail.com>, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com Subject: Re: [PATCH v2 1/3] staging: iio: ad7150: use FIELD_GET and GENMASK Message-ID: <20190616111802.51498c02@archlinux> In-Reply-To: <4f88fd66e478289006353645d84b7af1b5aa345c.1560529045.git.melissa.srw@gmail.com> References: <4f88fd66e478289006353645d84b7af1b5aa345c.1560529045.git.melissa.srw@gmail.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 14 Jun 2019 13:32:21 -0300 Melissa Wen wrote: > Use the bitfield macro FIELD_GET, and GENMASK to do the shift and mask in > one go. This makes the code more readable than explicit masking followed > by a shift. > > Signed-off-by: Melissa Wen Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to paly with it. Thanks, Jonathan > --- > drivers/staging/iio/cdc/ad7150.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c > index 8234da4b8c65..091aa33589d7 100644 > --- a/drivers/staging/iio/cdc/ad7150.c > +++ b/drivers/staging/iio/cdc/ad7150.c > @@ -5,6 +5,7 @@ > * Copyright 2010-2011 Analog Devices Inc. > */ > > +#include > #include > #include > #include > @@ -45,6 +46,9 @@ > #define AD7150_SN0 22 > #define AD7150_ID 23 > > +/* AD7150 masks */ > +#define AD7150_THRESHTYPE_MSK GENMASK(6, 5) > + > /** > * struct ad7150_chip_info - instance specific chip data > * @client: i2c client for this device > @@ -137,7 +141,7 @@ static int ad7150_read_event_config(struct iio_dev *indio_dev, > if (ret < 0) > return ret; > > - threshtype = (ret >> 5) & 0x03; > + threshtype = FIELD_GET(AD7150_THRESHTYPE_MSK, ret); > adaptive = !!(ret & 0x80); > > switch (type) {