From: Shobhit Kukreti <shobhitkukreti@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bastien Nocera <hadess@hadess.net>,
Hans de Goede <hdegoede@redhat.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: Resolve checkpatch error "that open brace { should be on the previous line" in the rtl8723 driver
Date: Sun, 16 Jun 2019 06:11:46 -0700 [thread overview]
Message-ID: <20190616131145.GA30779@t-1000> (raw)
In-Reply-To: <1d668acbce4cc9759cc940f56016dc9437df5441.camel@perches.com>
On Sun, Jun 16, 2019 at 01:13:11AM -0700, Joe Perches wrote:
> On Sat, 2019-06-15 at 14:29 -0700, Shobhit Kukreti wrote:
> > Cleaned up the code from the following files to get rid of
> > check patch error "that open brace { should be on the previous line"
>
> It's fine you are modifying brace styles, but:
>
> > diff --git a/drivers/staging/rtl8723bs/os_dep/mlme_linux.c b/drivers/staging/rtl8723bs/os_dep/mlme_linux.c
> > index aa2499f..4631b68 100644
> > --- a/drivers/staging/rtl8723bs/os_dep/mlme_linux.c
> > +++ b/drivers/staging/rtl8723bs/os_dep/mlme_linux.c
> > @@ -46,8 +46,7 @@ void rtw_os_indicate_connect(struct adapter *adapter)
> > struct mlme_priv *pmlmepriv = &(adapter->mlmepriv);
> >
> > if ((check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) == true) ||
> > - (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true))
> > - {
> > + (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true)) {
> > rtw_cfg80211_ibss_indicate_connect(adapter);
> > }
> > else
>
> the else should be on the same line as the close brace
>
> > @@ -106,8 +105,9 @@ void rtw_reset_securitypriv(struct adapter *adapter)
> > adapter->securitypriv.ndisencryptstatus = Ndis802_11WEPDisabled;
> >
> > }
> > - else /* reset values in securitypriv */
> > - {
> > + else {
> > + /* reset values in securitypriv */
> > +
>
> and here. etc. Please change all instances appropriately.
Thank you for the feedback. I intented to do one kind of change in a
patch. This probably would need a patch set. Will edit appropriately.
Best,
Shobhit Kukreti
>
>
next prev parent reply other threads:[~2019-06-16 13:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 2:12 [PATCH] staging: rtl8723bs: Resolve checkpatch error "that open brace { should be on the previous line" in the rtl8723bs driver Shobhit Kukreti
2019-06-15 18:53 ` Greg Kroah-Hartman
2019-06-15 21:29 ` [PATCH v2] staging: rtl8723bs: Resolve checkpatch error "that open brace { should be on the previous line" in the rtl8723 driver Shobhit Kukreti
2019-06-16 8:13 ` Joe Perches
2019-06-16 13:11 ` Shobhit Kukreti [this message]
2019-06-16 16:19 ` [PATCH v3 0/3] Resolve checkpatch if/else brace style errors Shobhit Kukreti
2019-06-16 16:19 ` [PATCH v3 1/3] staging: rtl8723bs: Resolve checkpatch error "that open brace { should be on the previous line" in the rtl8723 driver Shobhit Kukreti
2019-06-18 7:00 ` Greg Kroah-Hartman
2019-06-19 0:37 ` [PATCH v4 0/3] Resolve if/else brace-style errors Shobhit Kukreti
2019-06-19 0:37 ` [PATCH v4 1/3] staging: rtl8723bs: Resolve checkpatch error "that open brace { should be on the previous line" in the rtl8723 driver Shobhit Kukreti
2019-06-19 0:37 ` [PATCH v4 2/3] staging: rtl8723bs: Resolve the checkpatch error: else should follow close brace '}' Shobhit Kukreti
2019-06-19 0:37 ` [PATCH v4 3/3] staging: rtl8723bs: Fix Indentation Error: code indent should use tabs where possible Shobhit Kukreti
2019-06-16 16:19 ` [PATCH v3 2/3] staging: rtl8723bs: Resolve the checkpatch error: else should follow close brace '}' Shobhit Kukreti
2019-06-16 16:19 ` [PATCH v3 3/3] staging: rtl8723bs: Fix Indentation Error: code indent should use tabs where possible Shobhit Kukreti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190616131145.GA30779@t-1000 \
--to=shobhitkukreti@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox