From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 686B9C31E5C for ; Mon, 17 Jun 2019 14:41:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4246F2084A for ; Mon, 17 Jun 2019 14:41:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728484AbfFQOlO (ORCPT ); Mon, 17 Jun 2019 10:41:14 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:46668 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726331AbfFQOlO (ORCPT ); Mon, 17 Jun 2019 10:41:14 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 73FDF804A8; Mon, 17 Jun 2019 16:41:11 +0200 (CEST) Date: Mon, 17 Jun 2019 16:41:09 +0200 From: Sam Ravnborg To: Arnd Bergmann Cc: Harry Wentland , Leo Li , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , "David (ChunMing) Zhou" , David Airlie , Daniel Vetter , Thomas Lim , Eric Yang , Charlene Liu , Bhawanpreet Lakha , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Dmytro Laktyushkin , dri-devel@lists.freedesktop.org, Tony Cheng , Anthony Koo Subject: Re: [PATCH] drm/amd/display: include missing linux/delay.h Message-ID: <20190617144109.GA14528@ravnborg.org> References: <20190617123915.926526-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190617123915.926526-1-arnd@arndb.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VcLZwmh9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=5bNecMADuYMHRIO7LrIA:9 a=CjuIK1q_8ugA:10 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd. On Mon, Jun 17, 2019 at 02:38:55PM +0200, Arnd Bergmann wrote: > Some randconfig builds fail to compile the dcn10 code because of > a missing declaration: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In function 'dcn10_apply_ctx_for_surface': > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3: error: implicit declaration of function 'udelay' [-Werror=implicit-function-declaration] > > Include the appropriate kernel header. > > Fixes: 9ed43ef84d9d ("drm/amd/display: Add Underflow Asserts to dc") > Signed-off-by: Arnd Bergmann > --- > drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c > index 1ac9a4f03990..d87ddc7de9c6 100644 > --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c > +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c > @@ -22,6 +22,7 @@ > * Authors: AMD > * > */ > +#include > > #include > #include "dm_services.h" Something has gone wrong here, as you add a second include of linux/delay.h. We had this problem before, which Alex fixed by applying a patch to include linux/delay.h Sam