* [PATCH] drm/amd/display: include missing linux/delay.h
@ 2019-06-17 12:38 Arnd Bergmann
2019-06-17 14:41 ` Sam Ravnborg
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2019-06-17 12:38 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Alex Deucher, Christian König,
David (ChunMing) Zhou, David Airlie, Daniel Vetter
Cc: Arnd Bergmann, Thomas Lim, Eric Yang, Bhawanpreet Lakha,
Dmytro Laktyushkin, Tony Cheng, Anthony Koo, Charlene Liu,
amd-gfx, dri-devel, linux-kernel
Some randconfig builds fail to compile the dcn10 code because of
a missing declaration:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In function 'dcn10_apply_ctx_for_surface':
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3: error: implicit declaration of function 'udelay' [-Werror=implicit-function-declaration]
Include the appropriate kernel header.
Fixes: 9ed43ef84d9d ("drm/amd/display: Add Underflow Asserts to dc")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
index 1ac9a4f03990..d87ddc7de9c6 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
@@ -22,6 +22,7 @@
* Authors: AMD
*
*/
+#include <linux/delay.h>
#include <linux/delay.h>
#include "dm_services.h"
--
2.20.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/amd/display: include missing linux/delay.h
2019-06-17 12:38 [PATCH] drm/amd/display: include missing linux/delay.h Arnd Bergmann
@ 2019-06-17 14:41 ` Sam Ravnborg
2019-06-17 14:55 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Sam Ravnborg @ 2019-06-17 14:41 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Harry Wentland, Leo Li, Alex Deucher, Christian König,
David (ChunMing) Zhou, David Airlie, Daniel Vetter, Thomas Lim,
Eric Yang, Charlene Liu, Bhawanpreet Lakha, linux-kernel, amd-gfx,
Dmytro Laktyushkin, dri-devel, Tony Cheng, Anthony Koo
Hi Arnd.
On Mon, Jun 17, 2019 at 02:38:55PM +0200, Arnd Bergmann wrote:
> Some randconfig builds fail to compile the dcn10 code because of
> a missing declaration:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In function 'dcn10_apply_ctx_for_surface':
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3: error: implicit declaration of function 'udelay' [-Werror=implicit-function-declaration]
>
> Include the appropriate kernel header.
>
> Fixes: 9ed43ef84d9d ("drm/amd/display: Add Underflow Asserts to dc")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> index 1ac9a4f03990..d87ddc7de9c6 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> @@ -22,6 +22,7 @@
> * Authors: AMD
> *
> */
> +#include <linux/delay.h>
>
> #include <linux/delay.h>
> #include "dm_services.h"
Something has gone wrong here, as you add a second include of linux/delay.h.
We had this problem before, which Alex fixed by applying a patch to
include linux/delay.h
Sam
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/amd/display: include missing linux/delay.h
2019-06-17 14:41 ` Sam Ravnborg
@ 2019-06-17 14:55 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2019-06-17 14:55 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Harry Wentland, Leo Li, Alex Deucher, Christian König,
David (ChunMing) Zhou, David Airlie, Daniel Vetter, Thomas Lim,
Eric Yang, Charlene Liu, Bhawanpreet Lakha,
Linux Kernel Mailing List, amd-gfx, Dmytro Laktyushkin, dri-devel,
Tony Cheng, Anthony Koo
On Mon, Jun 17, 2019 at 4:41 PM Sam Ravnborg <sam@ravnborg.org> wrote:
> On Mon, Jun 17, 2019 at 02:38:55PM +0200, Arnd Bergmann wrote:
> > Some randconfig builds fail to compile the dcn10 code because of
> > a missing declaration:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c: In function 'dcn10_apply_ctx_for_surface':
> > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2378:3: error: implicit declaration of function 'udelay' [-Werror=implicit-function-declaration]
> >
> > Include the appropriate kernel header.
> >
> > Fixes: 9ed43ef84d9d ("drm/amd/display: Add Underflow Asserts to dc")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > index 1ac9a4f03990..d87ddc7de9c6 100644
> > --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> > @@ -22,6 +22,7 @@
> > * Authors: AMD
> > *
> > */
> > +#include <linux/delay.h>
> >
> > #include <linux/delay.h>
> > #include "dm_services.h"
>
> Something has gone wrong here, as you add a second include of linux/delay.h.
>
> We had this problem before, which Alex fixed by applying a patch to
> include linux/delay.h
My mistake, sorry about that. I had written and tested the patch on
last week's linux-next ernel and sent it out today after rebasing it, but did
not closely look at the resulting patch after the rebase.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-17 14:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-17 12:38 [PATCH] drm/amd/display: include missing linux/delay.h Arnd Bergmann
2019-06-17 14:41 ` Sam Ravnborg
2019-06-17 14:55 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox