* [PATCH] drm/nouveau/svm: Convert to use hmm_range_fault()
@ 2019-05-20 19:01 Souptick Joarder
2019-05-27 18:03 ` Souptick Joarder
2019-06-07 18:44 ` Souptick Joarder
0 siblings, 2 replies; 4+ messages in thread
From: Souptick Joarder @ 2019-05-20 19:01 UTC (permalink / raw)
To: bskeggs, airlied, daniel, jglisse
Cc: dri-devel, nouveau, linux-kernel, Souptick Joarder
Convert to use hmm_range_fault().
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
drivers/gpu/drm/nouveau/nouveau_svm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_svm.c b/drivers/gpu/drm/nouveau/nouveau_svm.c
index 93ed43c..8d56bd6 100644
--- a/drivers/gpu/drm/nouveau/nouveau_svm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_svm.c
@@ -649,7 +649,7 @@ struct nouveau_svmm {
range.values = nouveau_svm_pfn_values;
range.pfn_shift = NVIF_VMM_PFNMAP_V0_ADDR_SHIFT;
again:
- ret = hmm_vma_fault(&range, true);
+ ret = hmm_range_fault(&range, true);
if (ret == 0) {
mutex_lock(&svmm->mutex);
if (!hmm_vma_range_done(&range)) {
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/nouveau/svm: Convert to use hmm_range_fault()
2019-05-20 19:01 [PATCH] drm/nouveau/svm: Convert to use hmm_range_fault() Souptick Joarder
@ 2019-05-27 18:03 ` Souptick Joarder
2019-06-07 18:44 ` Souptick Joarder
1 sibling, 0 replies; 4+ messages in thread
From: Souptick Joarder @ 2019-05-27 18:03 UTC (permalink / raw)
To: bskeggs, airlied, Daniel Vetter, Jérôme Glisse
Cc: dri-devel, nouveau, linux-kernel
On Tue, May 21, 2019 at 12:27 AM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> Convert to use hmm_range_fault().
Any comment on this patch ?
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
> drivers/gpu/drm/nouveau/nouveau_svm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_svm.c b/drivers/gpu/drm/nouveau/nouveau_svm.c
> index 93ed43c..8d56bd6 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_svm.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_svm.c
> @@ -649,7 +649,7 @@ struct nouveau_svmm {
> range.values = nouveau_svm_pfn_values;
> range.pfn_shift = NVIF_VMM_PFNMAP_V0_ADDR_SHIFT;
> again:
> - ret = hmm_vma_fault(&range, true);
> + ret = hmm_range_fault(&range, true);
> if (ret == 0) {
> mutex_lock(&svmm->mutex);
> if (!hmm_vma_range_done(&range)) {
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/nouveau/svm: Convert to use hmm_range_fault()
2019-05-20 19:01 [PATCH] drm/nouveau/svm: Convert to use hmm_range_fault() Souptick Joarder
2019-05-27 18:03 ` Souptick Joarder
@ 2019-06-07 18:44 ` Souptick Joarder
2019-06-17 19:54 ` Jerome Glisse
1 sibling, 1 reply; 4+ messages in thread
From: Souptick Joarder @ 2019-06-07 18:44 UTC (permalink / raw)
To: bskeggs, airlied, Daniel Vetter, Jérôme Glisse, jasojgg
Cc: dri-devel, nouveau, linux-kernel
Hi Jason,
On Tue, May 21, 2019 at 12:27 AM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> Convert to use hmm_range_fault().
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Would you like to take it through your new hmm tree or do I
need to resend it ?
> ---
> drivers/gpu/drm/nouveau/nouveau_svm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_svm.c b/drivers/gpu/drm/nouveau/nouveau_svm.c
> index 93ed43c..8d56bd6 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_svm.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_svm.c
> @@ -649,7 +649,7 @@ struct nouveau_svmm {
> range.values = nouveau_svm_pfn_values;
> range.pfn_shift = NVIF_VMM_PFNMAP_V0_ADDR_SHIFT;
> again:
> - ret = hmm_vma_fault(&range, true);
> + ret = hmm_range_fault(&range, true);
> if (ret == 0) {
> mutex_lock(&svmm->mutex);
> if (!hmm_vma_range_done(&range)) {
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/nouveau/svm: Convert to use hmm_range_fault()
2019-06-07 18:44 ` Souptick Joarder
@ 2019-06-17 19:54 ` Jerome Glisse
0 siblings, 0 replies; 4+ messages in thread
From: Jerome Glisse @ 2019-06-17 19:54 UTC (permalink / raw)
To: Souptick Joarder
Cc: bskeggs, airlied, Daniel Vetter, jasojgg, dri-devel, nouveau,
linux-kernel
On Sat, Jun 08, 2019 at 12:14:50AM +0530, Souptick Joarder wrote:
> Hi Jason,
>
> On Tue, May 21, 2019 at 12:27 AM Souptick Joarder <jrdr.linux@gmail.com> wrote:
> >
> > Convert to use hmm_range_fault().
> >
> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>
> Would you like to take it through your new hmm tree or do I
> need to resend it ?
This patch is wrong as the API is different between the two see what
is in hmm.h to see the differences between hmm_vma_fault() hmm_range_fault()
a simple rename break things.
>
> > ---
> > drivers/gpu/drm/nouveau/nouveau_svm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/nouveau/nouveau_svm.c b/drivers/gpu/drm/nouveau/nouveau_svm.c
> > index 93ed43c..8d56bd6 100644
> > --- a/drivers/gpu/drm/nouveau/nouveau_svm.c
> > +++ b/drivers/gpu/drm/nouveau/nouveau_svm.c
> > @@ -649,7 +649,7 @@ struct nouveau_svmm {
> > range.values = nouveau_svm_pfn_values;
> > range.pfn_shift = NVIF_VMM_PFNMAP_V0_ADDR_SHIFT;
> > again:
> > - ret = hmm_vma_fault(&range, true);
> > + ret = hmm_range_fault(&range, true);
> > if (ret == 0) {
> > mutex_lock(&svmm->mutex);
> > if (!hmm_vma_range_done(&range)) {
> > --
> > 1.9.1
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-17 19:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-20 19:01 [PATCH] drm/nouveau/svm: Convert to use hmm_range_fault() Souptick Joarder
2019-05-27 18:03 ` Souptick Joarder
2019-06-07 18:44 ` Souptick Joarder
2019-06-17 19:54 ` Jerome Glisse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox