From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Cc: Michael Straube <straube.linux@gmail.com>,
Mamta Shukla <mamtashukla555@gmail.com>,
Nishka Dasgupta <nishkadg.linux@gmail.com>,
Emanuel Bennici <benniciemanuel78@gmail.com>,
Puranjay Mohan <puranjay12@gmail.com>,
Shobhit Kukreti <shobhitkukreti@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [Patch v2] staging: rtl8723bs: os_dep: ioctl_linux: make use of kzalloc
Date: Tue, 18 Jun 2019 08:57:53 +0200 [thread overview]
Message-ID: <20190618065753.GA15358@kroah.com> (raw)
In-Reply-To: <20190618014410.GA8505@hari-Inspiron-1545>
On Tue, Jun 18, 2019 at 07:14:10AM +0530, Hariprasad Kelam wrote:
> kmalloc with memset can be replaced with kzalloc.
Yes, but did you audit the call-paths of this to ensure that GFP_KERNEL
is the correct value for kzalloc() here? If so, please document that in
the changelog.
thanks,
greg k-h
next prev parent reply other threads:[~2019-06-18 6:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 1:44 [Patch v2] staging: rtl8723bs: os_dep: ioctl_linux: make use of kzalloc Hariprasad Kelam
2019-06-18 6:57 ` Greg Kroah-Hartman [this message]
2019-06-18 8:55 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618065753.GA15358@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=benniciemanuel78@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=hariprasad.kelam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mamtashukla555@gmail.com \
--cc=nishkadg.linux@gmail.com \
--cc=puranjay12@gmail.com \
--cc=shobhitkukreti@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox