From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A3A7C31E51 for ; Tue, 18 Jun 2019 07:49:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D37292084D for ; Tue, 18 Jun 2019 07:49:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560844148; bh=5s30GomD44N92xGZszrfWfrIiZv9xCuvrxnPayt45R8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=k9ps2tmXjRWhzXkZtUVveuz6fUjB3KD+SFUPXxr4pWI4oNlOPgR2SOXiCdacbGM6y MdsLhgBDB1VfVUo03eBTvWMrS9876dIYAAxSEIgDLCu/QyN9zQq5MEeqdr6ecplezQ wufuRwvyzCCN85/eHL3sye9swJsIf/IfUhff/hqk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727186AbfFRHtH (ORCPT ); Tue, 18 Jun 2019 03:49:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:60226 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725870AbfFRHtG (ORCPT ); Tue, 18 Jun 2019 03:49:06 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 87CB120663; Tue, 18 Jun 2019 07:49:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560844146; bh=5s30GomD44N92xGZszrfWfrIiZv9xCuvrxnPayt45R8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vXHzl4rTLK5B2MQBjMB7daMyhCH0b6oHm8NOrBCUaIAO4Rl2YuzkoOiDS8d7WntPK xUEKOhsQlG77RjUWW+WzokOgbFd0pejnYlX9zU2QBGguNYnTiWErh/UA29nQCsKG2C Guzaku0nCrA+RGI2mXHwXzUVZYQP+Ti3e07sXrY4= Date: Tue, 18 Jun 2019 09:49:03 +0200 From: Greg Kroah-Hartman To: Stefan Roese Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Yegor Yefremov , Mika Westerberg , Andy Shevchenko , Giulio Benetti Subject: Re: [PATCH 2/2 v5] tty/serial/8250: use mctrl_gpio helpers Message-ID: <20190618074903.GA5216@kroah.com> References: <20190611105603.4435-1-sr@denx.de> <20190611105603.4435-2-sr@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190611105603.4435-2-sr@denx.de> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 11, 2019 at 12:56:03PM +0200, Stefan Roese wrote: > From: Yegor Yefremov > > This patch permits the usage for GPIOs to control > the CTS/RTS/DTR/DSR/DCD/RI signals. > > Changed by Stefan: > Only call mctrl_gpio_init(), if the device has no ACPI companion device > to not break existing ACPI based systems. Also only use the mctrl_gpio_ > functions when "gpios" is available. > > Signed-off-by: Yegor Yefremov > Signed-off-by: Greg Kroah-Hartman Please do not add a signed-off-by from people for an old patch that was reverted. It implies that I still agree with this change :( greg k-h