From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BE32C31E51 for ; Tue, 18 Jun 2019 07:29:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B3FD2080C for ; Tue, 18 Jun 2019 07:29:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728977AbfFRH3H (ORCPT ); Tue, 18 Jun 2019 03:29:07 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:59258 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725870AbfFRH3H (ORCPT ); Tue, 18 Jun 2019 03:29:07 -0400 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 6B5CB260C4A; Tue, 18 Jun 2019 08:29:04 +0100 (BST) Date: Tue, 18 Jun 2019 09:29:01 +0200 From: Boris Brezillon To: masonccyang@mxic.com.tw Cc: "Miquel Raynal" , bbrezillon@kernel.org, broonie@kernel.org, christophe.kerello@st.com, computersforpeace@gmail.com, devicetree@vger.kernel.org, dwmw2@infradead.org, geert@linux-m68k.org, juliensu@mxic.com.tw, lee.jones@linaro.org, liang.yang@amlogic.com, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, marcel.ziswiler@toradex.com, marek.vasut@gmail.com, mark.rutland@arm.com, paul.burton@mips.com, richard@nod.at, robh+dt@kernel.org, stefan@agner.ch, zhengxunli@mxic.com.tw Subject: Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller Message-ID: <20190618092901.3bdd9f61@collabora.com> In-Reply-To: <20190618081436.5d488320@collabora.com> References: <1555320234-15802-1-git-send-email-masonccyang@mxic.com.tw> <1555320234-15802-3-git-send-email-masonccyang@mxic.com.tw> <20190512151820.4f2dd9da@xps13> <20190520142333.390091d5@xps13> <20190527144250.71908bd9@xps13> <20190617143510.4ded5728@xps13> <20190618081436.5d488320@collabora.com> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 18 Jun 2019 08:14:36 +0200 Boris Brezillon wrote: > > > > > > > > > > > > How to make all #CS keep high for NAND to enter > > > > > > low-power standby mode if driver don't use "legacy.select_chip()" > > ? > > > > > > > > > > See commit 02b4a52604a4 ("mtd: rawnand: Make ->select_chip() > > optional > > > > > when ->exec_op() is implemented") which states: > > > > > > > > > > "When [->select_chip() is] not implemented, the core is > > assuming > > > > > the CS line is automatically asserted/deasserted by the driver > > > > > ->exec_op() implementation." > > > > > > > > > > Of course, the above is right only when the controller driver > > supports > > > > > the ->exec_op() interface. > > > > > > > > Currently, it seems that we will get the incorrect data and error > > > > operation due to CS in error toggling if CS line is controlled in > > > > ->exec_op(). Oh, and please provide the modifications you added on top of this patch. Right now we're speculating on what you've done which is definitely not an efficient way to debug this sort of issues.