From: Jonathan Corbet <corbet@lwn.net>
To: Valentin Schneider <valentin.schneider@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH] docs/vm: hwpoison.rst: Fix quote formatting
Date: Tue, 18 Jun 2019 09:31:59 -0600 [thread overview]
Message-ID: <20190618093159.26352aed@lwn.net> (raw)
In-Reply-To: <20190618145605.21208-1-valentin.schneider@arm.com>
On Tue, 18 Jun 2019 15:56:05 +0100
Valentin Schneider <valentin.schneider@arm.com> wrote:
> The asterisks prepended to the quoted text currently get translated to
> bullet points, which gets increasingly confusing the smaller your
> screen is (when viewing the sphinx output, that is).
>
> Convert the whole quote to a literal block.
>
> Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
That definitely seems worth fixing, and I can apply this. But a few
things to ponder first...
- If you convert it to a literal block, the asterisks can remain, making
for a less intrusive patch.
- I was wondering if we should just use a kernel-doc directive to pull
the comment directly from the source, but investigation quickly showed
that the "overview comment" doesn't actually exist in anything close to
the quoted form. See mm/memory-failure.c.
Given that, and things like references to support in "upcoming Intel
CPUs", I suspect that this document is pretty seriously out of date and
needs some more in-depth attention. If you're playing in this area and
feel like it, updating the document for real would be much appreciated...:)
Thanks,
jon
next prev parent reply other threads:[~2019-06-18 15:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 14:56 [PATCH] docs/vm: hwpoison.rst: Fix quote formatting Valentin Schneider
2019-06-18 15:31 ` Jonathan Corbet [this message]
2019-06-18 15:51 ` Valentin Schneider
2019-06-18 20:45 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618093159.26352aed@lwn.net \
--to=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox