Re: [Linux-kernel-mentees] [PATCH v2] fs: cramfs_fs.h: Fix shifting signed 32-bit value by 31 bits problem

Shuah Khan
2019-06-18T16:15:18Z

On 6/18/19 10:08 AM, Greg KH wrote:
> On Tue, Jun 18, 2019 at 05:19:47PM +0530, Puranjay Mohan wrote:
>> Fix CRAMFS_BLK_FLAG_UNCOMPRESSED to use "U" cast to avoid shifting signed
>> 32-bit value by 31 bits problem. This isn't a problem for kernel builds
>> with gcc.
>>
>> This could be problem since this header is part of public API which
>> could be included for builds using compilers that don't handle this
>> condition safely resulting in undefined behavior.
>>
>> Signed-off-by: Puranjay Mohan <puranjay12@gmail.com>
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> You should resend this and cc: Nicolas Pitre <nico@fluxnic.net> as he is
> the cramfs maintainer.
>

Puranjay! You can add all the Reviewed-by tags when you resend the patch
with Nicolas Pitre <nico@fluxnic.net> on the thread.

Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah