From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41767C31E51 for ; Tue, 18 Jun 2019 12:18:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1636A20665 for ; Tue, 18 Jun 2019 12:18:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="wGkcfosB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728656AbfFRMSX (ORCPT ); Tue, 18 Jun 2019 08:18:23 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:52520 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725913AbfFRMSX (ORCPT ); Tue, 18 Jun 2019 08:18:23 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5IC3cFi179647; Tue, 18 Jun 2019 12:18:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=LgB+9qdWHrQsH3RvkDcwaILpNR9kYf/0G8hl092s7dI=; b=wGkcfosBVlI3iWMNa43Bw6hmlrmi7maXlAHvF33sxTnnMhJIB8JQc3NMTFoaUhzMEHdh N8l9csosjxnPOJqXnZabxGsYQMMJwolcpBEkGLGxKUcu/nHbn/lqVhuOQo+iz6gtKj+F 9FljCyJ+DYMEJo1UIemHR9iLx1df0KmpJcqA9x0Np+EzApl0Xvz50vDiAFGM5qcfnMMO 1kM7Lh2/V7dKUXJf5M1Yz8lyX7x0z+kua5X2e+w/dCIO2WNqFTuw1+SaoexhZoNrElaB HSojpxfX6DEdzdZptMjhcbEzanrWmpELopzdws4Ql0f1UTBiy45hA1lyRiXj7ro8emgx gg== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 2t4saqc2d1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 18 Jun 2019 12:18:11 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5ICGQx5191009; Tue, 18 Jun 2019 12:18:10 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3020.oracle.com with ESMTP id 2t5mgbwsck-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 18 Jun 2019 12:18:10 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x5ICI6KT032512; Tue, 18 Jun 2019 12:18:06 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 18 Jun 2019 05:18:05 -0700 Date: Tue, 18 Jun 2019 15:17:56 +0300 From: Dan Carpenter To: syzbot Cc: arve@android.com, christian@brauner.io, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, joel@joelfernandes.org, linux-kernel@vger.kernel.org, maco@android.com, syzkaller-bugs@googlegroups.com, tkjos@android.com, tkjos@google.com Subject: Re: kernel BUG at drivers/android/binder_alloc.c:LINE! (4) Message-ID: <20190618121756.GL28859@kadam> References: <000000000000b6b25b058b96d5c3@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000000000000b6b25b058b96d5c3@google.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9291 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=572 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906180100 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9291 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=636 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906180100 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It's weird that that binder_alloc_copy_from_buffer() is a void function. It would be easier to do the error handling at that point, instead of in the callers. It feels like we keep hitting similar bugs to this. regards, dan carpenter