From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A774C31E5B for ; Tue, 18 Jun 2019 16:08:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3063620B1F for ; Tue, 18 Jun 2019 16:08:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560874133; bh=YCsNI3NUEf3Ql1pa6VJY/tDOkScY+nHIByu9NbnC36Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=wxIrgP7vf+bQjRI3PB1CitiujkmMc2olAKRg3vNJcxN1j16ww0m6t4dHf93IBjxLM ayI8TSOQS/l+9OeAUQpXZDJsXfVj7r7evmJsD0ga2CRRbpJiKcbHkrcNO4N9hu3SUz XvwT7WqImcHawz+CLhRiNunNwm0QjL6d4PdLuPJI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729893AbfFRQIv (ORCPT ); Tue, 18 Jun 2019 12:08:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:48366 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729247AbfFRQIu (ORCPT ); Tue, 18 Jun 2019 12:08:50 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7A80C213F2; Tue, 18 Jun 2019 16:08:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560874130; bh=YCsNI3NUEf3Ql1pa6VJY/tDOkScY+nHIByu9NbnC36Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0YKi/KzPywEj1N8qH2KtYtm/gAy7MGUSAmSjnLozqZfHcQkhJAsnU26kBZW3TnOs3 x050ZxqF1ZgcYIvK+f5UqVtG8lb76QINYtwEW8rJcere9TfZck1vQOubHmTKC07Jd7 ty3Y8cr9LSJxKvrBnJqvaycxBX2cJ6GxEC26G9m0= Date: Tue, 18 Jun 2019 18:08:47 +0200 From: Greg KH To: Puranjay Mohan Cc: Shuah Khan , hch@infradead.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [Linux-kernel-mentees] [PATCH v2] fs: cramfs_fs.h: Fix shifting signed 32-bit value by 31 bits problem Message-ID: <20190618160847.GC27611@kroah.com> References: <20190618114947.10563-1-puranjay12@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190618114947.10563-1-puranjay12@gmail.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 18, 2019 at 05:19:47PM +0530, Puranjay Mohan wrote: > Fix CRAMFS_BLK_FLAG_UNCOMPRESSED to use "U" cast to avoid shifting signed > 32-bit value by 31 bits problem. This isn't a problem for kernel builds > with gcc. > > This could be problem since this header is part of public API which > could be included for builds using compilers that don't handle this > condition safely resulting in undefined behavior. > > Signed-off-by: Puranjay Mohan Reviewed-by: Greg Kroah-Hartman You should resend this and cc: Nicolas Pitre as he is the cramfs maintainer. thanks, greg k-h