From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Simon Sandström" <simon@nikanor.nu>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: kpc2000: simplify error handling in kp2000_pcie_probe
Date: Wed, 19 Jun 2019 09:53:06 +0300 [thread overview]
Message-ID: <20190619065306.GN28859@kadam> (raw)
In-Reply-To: <20190619063607.20722-1-simon@nikanor.nu>
On Wed, Jun 19, 2019 at 08:36:07AM +0200, Simon Sandström wrote:
> We can get rid of a few iounmaps in the middle of the function by
> re-ordering the error handling labels and adding two new labels.
>
> Signed-off-by: Simon Sandström <simon@nikanor.nu>
> ---
>
> This change has not been tested besides by compiling. It might be good
> took take an extra look to make sure that I got everything right.
>
You have the right instincts that when something looks really
complicated that's probably for a reason. That attitude will serve you
well in the future! But in this case it's staging code so the original
code is just strange.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
> Also, this change was proposed by Dan Carpenter. Should I add anything
> in the commit message to show this?
There is a Suggested-by: tag for this, but don't resend because I don't
care and I've already reviewed this version so I don't want to review
the patch again.
regards,
dan carpenter
prev parent reply other threads:[~2019-06-19 6:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 6:36 [PATCH] staging: kpc2000: simplify error handling in kp2000_pcie_probe Simon Sandström
2019-06-19 6:53 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190619065306.GN28859@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=simon@nikanor.nu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox