Re: [PATCH v3 1/4] mfd: Add Macronix MX25F0A MFD controller driver

Miquel Raynal
2019-05-12T13:08:29Z

Hi Mason,

Mason Yang <masonccyang@mxic.com.tw> wrote on Mon, 15 Apr 2019 17:23:51
+0800:

> Add a driver for Macronix MX25F0A multifunction device controller.
>
> Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
> ---
> drivers/mfd/Kconfig | 9 ++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/mxic-mx25f0a.c | 84 +++++++++++++++++++
> include/linux/mfd/mxic-mx25f0a.h | 175 +++++++++++++++++++++++++++++++++++++++
> 4 files changed, 269 insertions(+)
> create mode 100644 drivers/mfd/mxic-mx25f0a.c
> create mode 100644 include/linux/mfd/mxic-mx25f0a.h
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 26ad646..7e99e93 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -823,6 +823,15 @@ config MFD_MAX8998
> additional drivers must be enabled in order to use the functionality
> of the device.
>
> +config MFD_MXIC_MX25F0A
> + tristate "Macronix mx25f0a multifunction device support"
> + select MFD_CORE
> + help
> + This supports for Macronix mx25f0a multifunction device controller
> + for raw nand or spi. You have to select individual components like

Please use upper case for acronyms in plain English: NAND, SPI

> + raw nand controller or spi host controller under the corresponding
> + menus.
> +
> config MFD_MT6397
> tristate "MediaTek MT6397 PMIC Support"
> select MFD_CORE

Thanks,
Miquèl