Re: [PATCH v3 2/4] mtd: rawnand: Add Macronix MX25F0A NAND controller

Miquel Raynal
2019-05-15T12:09:12Z

Hi masonccyang@mxic.com.tw,

masonccyang@mxic.com.tw wrote on Wed, 15 May 2019 16:48:46 +0800:

> Hi Miquel,
>
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +//
> > > +// Copyright (C) 2019 Macronix International Co., Ltd.
> > > +//
> > > +// Authors:
> > > +// Mason Yang <masonccyang@mxic.com.tw>
> > > +// zhengxunli <zhengxunli@mxic.com.tw>
> >
> > This is not a valid name.
> >
> > Also if he appears here I suppose he should be credited in the
> > module_authors() macro too.
>
> I think Li should maintain this NAND driver later,

This entry is for the authors of the driver.

If he will maintain the driver, then add a new entry in MAINTAINERS.

> > > +}
> > > +
> > > +static const struct nand_controller_ops mxic_nand_controller_ops = {
> > > + .exec_op = mxic_nand_exec_op,
> > > +};
> > > +
> > > +static int mx25f0a_nand_probe(struct platform_device *pdev)
> > > +{
> > > + struct mtd_info *mtd;
> > > + struct mx25f0a_mfd *mfd = dev_get_drvdata(pdev->dev.parent);
> > > + struct mxic_nand_ctlr *mxic;
> > > + struct nand_chip *nand_chip;
> > > + int err;
> > > +
> > > + mxic = devm_kzalloc(&pdev->dev, sizeof(struct mxic_nand_ctlr),
> > > + GFP_KERNEL);
> >
> > mxic for a NAND controller structure is probably not a name meaningful
> > enough.
>
> How about *fmc or *mxic_fmc ?

fmc is fine, even if I personally prefer nfc for NAND flash controller.
Here the 'm' in fmc stands for 'memory' but I am not sure if the
controller can manage something else than NAND flash anyway?

Thanks,
Miquèl